[Bug 243971] [NEW PORT] www/py-gdown: Download files from google drive
bugzilla-noreply at freebsd.org
bugzilla-noreply at freebsd.org
Sun Feb 9 02:58:20 UTC 2020
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243971
--- Comment #2 from Shane <FreeBSD at ShaneWare.Biz> ---
I just thought requests[socks] was part of www/py-requests.
py-requests depends on py-urllib3 which optionally depends on py-pysocks, and
is on by default.
gdown passes any proxy options to requests through `sess.proxies = {...}` then
the call to `sess.get()` is in a try block which catches proxy errors. That
should leave a nice failed message if trying to use a proxy with SOCKS
disabled/unavailable in py-urllib3.
https://github.com/wkentaro/gdown/blob/master/gdown/download.py#L66
So as gdown doesn't directly rely on or call py-pysocks, does that count as
needing to be listed as an optional port dependency? It does mean the projects
setup.py could use some adjustment.
--
You are receiving this mail because:
You are on the CC list for the bug.
More information about the freebsd-python
mailing list