maintainer-feedback requested: [Bug 243937] lang/python38: really disable tkinter, sqlite3, gdbm modules (fixes check-plist)

[bugzilla-noreply at freebsd.org]

Bugzilla Automation <bugzilla at FreeBSD.org> has asked freebsd-python mailing
list <python at FreeBSD.org> for maintainer-feedback:
Bug 243937: lang/python38: really disable tkinter, sqlite3, gdbm modules (fixes
check-plist)
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243937



--- Description ---
make check-plist gives errors for lang/python38 ...


====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: lib/python%%XYDOT%%/lib-dynload/_gdbm.so
Error: Orphaned: lib/python%%XYDOT%%/lib-dynload/_sqlite3.so
Error: Orphaned: lib/python%%XYDOT%%/lib-dynload/_tkinter.so
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1


The attached patch fixes the check-plist error (and avoids building the modules
saving a bit of build time) by using Modules/Setup.

See also https://bugs.python.org/issue20210

The fix could also be applied to python37 (and then we could remove the
files/patch-issue20210 and DISABLED_EXTENSIONS in Makefile).