[Bug 240476] security/py-fido2: Add FreeBSD support

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240476

Kubilay Kocak <koobs at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |needs-patch

--- Comment #15 from Kubilay Kocak <koobs at FreeBSD.org> ---
Thanks Michael, nice work upstreaming. 

A couple of leftovers:

- RUN_DEPENDS don't also need to be in TEST_DEPENDS (uhid-freebsd)
- setup.py says uhid-freebsd>=1.2.1, RUN_DEPENDS says >=1.0. *_DEPENDS should
match upstream requirements as closely as possible modulo any syntax
limitations we have (we cant foo!=x.y right now for example)

On the test suite with OS specific tests, upstreams should always 'skip' these
tests if the environment isn't appropriate for the test. pytest and nose have
very easy decorators upstreams can use to do this with various condition
support)

When test suites 'dont' skip inappropriate tests, one can usually (with most
unittest frameworks), skip individual tests explicitly in the test invocation.

For example with pytest you can -k 'not <expression>' and with nose you can
-e{xclude} <regex>

With unittest (in Python > 3.1) you can skipIf [1], i cant recall if there's a
command line arg for skipping tests. Also, if the tests use 'unittest', then
the Python package should probably tests_require on "unittest2; python_version
< 3"

[1] https://docs.python.org/3/library/unittest.html#unittest.skipIf

-- 
You are receiving this mail because:
You are the assignee for the bug.