[Bug 236038] [NEW PORT] net-mgmt/py-nxapi_plumbing: Manage Cisco Nexus via JSON-RPC and XML

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236038

Kubilay Kocak <koobs at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|easy, patch, patch-ready    |feature
             Status|New                         |Open

--- Comment #1 from Kubilay Kocak <koobs at FreeBSD.org> ---
Thanks John,

Review items: 

- Minor: Match a projects upstream description (setup.py:description) as
closely as possible, with COMMENT (portlint) compliance changes where
necessary. In this case "Library for managing Cisco devices through NX-API
using XML or jsonrpc"

- Projects setup.py:url is a 404, can you send an upstream issue/PR to correct
it

- sdist includes tests and a test command (in tox.ini not shipped in sdist).
Add TEST_DEPENDS (pytest) and a do(test) target for QA. The following should
work:

do-test:
    @cd ${WRKSRC}} && ${PYTHON_CMD} -m pytest -v -s test

Would be great to confirm those tests pass as well

-- 
You are receiving this mail because:
You are on the CC list for the bug.