[Bug 235585] textproc/py-pyhamcrest: Update incompletely specified Python version support

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Wed Feb 13 02:13:41 UTC 2019


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235585

Kubilay Kocak <koobs at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|maintainer-feedback?(python |maintainer-feedback+
                   |@FreeBSD.org)               |
            Summary|textproc/py-pyhamcrest      |textproc/py-pyhamcrest:
                   |build for all python        |Update incompletely
                   |versions                    |specified Python version
                   |                            |support
             Status|New                         |Open
           Keywords|                            |easy

--- Comment #2 from Kubilay Kocak <koobs at FreeBSD.org> ---
Python ports should declare the python versions that package *supports*, as
accurately and precisely as possible without being incorrect, within the
current limitations of the USES=python:<version-spec> specification syntax.

Generally speaking, if there is a package A (eg: Twisted), that supports Python
version X.Y (3.6), that depends on a package B (pyhamcrest, which is unclear or
does not explicitly state X.Y (3.6) support), either:

 1) Package A's (twisted) dependencies are incorrectly specified/qualified, OR
 2) Package B's (pyhamcrest) version support is incompletely specified.

Package A couldn't possibly support X.Y (3.6) if a dependency B didn't/doesn't
also. 

Some upstream data points:

* pyhamcrest upstream appears to be testing up to 3.6 [1][2]

In this case it appears that (2) is more likely. Twisted is very well tested,
and they include optional dependencies in their CI builds, which would be
publicly failing for 3.4+ python versions if one of their dependencies didn't
support that version.

Test suits are by far the most valuable thing QA tool for us as packagers, so
add TEST_DEPENDS [3] and a (do-)test: target [4] to test pyhamcrest on 3.5/3.6.

[1] https://github.com/hamcrest/PyHamcrest/blob/master/.travis.yml#L14
[2] https://github.com/hamcrest/PyHamcrest/blob/master/tox.ini#L2
[3] setup.py:test_dependencies = ['hypothesis>=1.11', 'pytest>=2.8',
[4] setup.py:cmdclass={'test': PyTest} (PYTHON_CMD PYDISTUTILS_SETUP test)

P.S: Please send PR's upstream to add update docs and classifiers (setup.py) to
include later python versions if they are confirmed to pass tests

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the freebsd-python mailing list