[Bug 221889] [NEW PORT] www/py-treq: Requests-like API built on top of twisted.web's Agent

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221889

Kubilay Kocak <koobs at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.freebsd.org/bu
                   |                            |gzilla/show_bug.cgi?id=2221
                   |                            |81
           Keywords|needs-patch, needs-qa       |

--- Comment #3 from Kubilay Kocak <koobs at FreeBSD.org> ---
I might split out the twisted[tls] dependencies [1] into a separate/additional
RUN_DEPENDS section with a comment, so our future selves know the
context/special treatment of those deps:

# Depend directly on twisted[tls] dependencies
# As Twisted port may not (optionally) install them
RUN_DEPENDS+=
  ${PYTHON_PKGNAMEPREFIX}openssl>=16.0.0:security/py-openssl \
  ${PYTHON_PKGNAMEPREFIX}service_identity>=16.0.0:security/py-service_identity
\
  ${PYTHON_PKGNAMEPREFIX}idna>=2.4:dns/py-idna

[1]
https://github.com/twisted/twisted/blob/trunk/src/twisted/python/_setup.py#L93

Other than that the change looks OK.

-- 
You are receiving this mail because:
You are on the CC list for the bug.