[Bug 221889] [NEW PORT] www/py-treq: Requests-like API built on top of twisted.web's Agent

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221889

Kubilay Kocak <koobs at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |python at FreeBSD.org
           Keywords|                            |feature, needs-patch,
                   |                            |needs-qa
             Status|New                         |Open

--- Comment #1 from Kubilay Kocak <koobs at FreeBSD.org> ---
Looks OK, a few considerations:

- Ideally, MAINTAINER for new ports should be author unless compelling reason
not to be. python is happy to be a fallback in the case of maintainers falling
away over time however.

- Consider invoking trial via "${PYTHON_CMD} -m
<something.trial|trial.something>"  rather than localbase scripts, which cannot
be relied upon to point to the same/expected version of Python over time (users
can change 'default' version of python at any time).

- Add LICENSE_FILE if one exists (or is provided by) in WKRSRC (extracted
tarball). One is provided (named LICENSE)

- Upstream 'Trove classifiers' specify 2.7+ support (2.7,3.3+ precisely), but
USES=python is limited to -2.7:

    "Programming Language :: Python :: 2.7",
    "Programming Language :: Python :: 3.3",
    "Programming Language :: Python :: 3.4",
    "Programming Language :: Python :: 3.5",

- install_requires depends explicitly on "Twisted[tls] >= 16.4.0", you may want
this port to depend 'explicitly' on those optional 'tls' python packages to
ensure they're installed (the twisted port may or may not install them, as
they're, well, optional)

Confirmation of QA also not provided

-- 
You are receiving this mail because:
You are on the CC list for the bug.