[Differential] D10162: Summary: Change to buildbot 0.9.5

grembo (Michael Gmelin) phabric-noreply at FreeBSD.org
Tue Mar 28 20:24:52 UTC 2017


grembo added a comment.


  @rodrigc This commit by you brakes most of the unit tests:
  
    commit dc8824e60d005f312693c077369be16bab75eace
    Author: Craig Rodrigues <rodrigc at FreeBSD.org>
    Date:   Wed Feb 15 02:11:43 2017 -0800
    
        Replace platform.linux_distribution() with distro.linux_distribution().
        
        platform.linux_distribution() is deprecated in Python 3.
    
    diff --git a/master/setup.py b/master/setup.py
    index b614299..c4adce6 100755
    --- a/master/setup.py
    +++ b/master/setup.py
    @@ -444,6 +444,7 @@ setup_args['install_requires'] = [
         'txaio ' + txaio_ver,
         'autobahn ' + autobahn_ver,
         'PyJWT',
    +    'distro'
     ]
     
     # Unit test dependencies.
  
  AFAIK there is no distro package available for FreeBSD (as it's Linux only). I opened a pull request upstream:
  https://github.com/buildbot/buildbot/pull/3087
  
  Also, the package on pypi lacks secrets/providers (the subdirectory is simply missing) which breaks additional tests (and probably will lead to runtime errors as well).
  
  I opened an issue on github, as I'm not sure how these packages are created:
  https://github.com/buildbot/buildbot/issues/3086
  
  I'll patch around those problems in the ports tree for the moment, but the solutions should happen upstream.

REPOSITORY
  rP FreeBSD ports repository

REVISION DETAIL
  https://reviews.freebsd.org/D10162

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: rodrigc, grembo, freebsd-python-list
Cc: mat


More information about the freebsd-python mailing list