[Bug 219687] [NEW PORT] net/google-compute-engine: User daemon for Google Compute Engine

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219687

Kubilay Kocak <koobs at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |python at FreeBSD.org
             Status|New                         |Open
            Summary|[NEW PORT]                  |[NEW PORT]
                   |net/google-compute-engine:  |net/google-compute-engine:
                   |user daemon for Google      |User daemon for Google
                   |Compute Engine              |Compute Engine
              Flags|                            |maintainer-feedback?(helen.
                   |                            |koike at collabora.com)
           Keywords|                            |feature, needs-patch,
                   |                            |needs-qa
           Priority|---                         |Normal
           Assignee|freebsd-ports-bugs at FreeBSD. |koobs at FreeBSD.org
                   |org                         |

--- Comment #8 from Kubilay Kocak <koobs at FreeBSD.org> ---
Thank you for your new port contribution Helen.

Pending further review, initial review items (needing updated patch) are:

- Add missing PKGNAMEPREFIX=${PYTHON_PKGNAMEPREFIX}
- Missing secondary 'python' virtual category in CATEGORIES 
- Add USE_PYTHON=concurrent if the port is multiple python version concurrent
installation safe (all files are uniquely named and dont conflict)
- Use 'CHEESESHOP' (PyPI) as MASTER_SITES unless there is a compelling reason
not to (for instance, test or other important files missing from source
distribution on PyPI)
- Add test support (using do-test: target), adding TEST_DEPENDS (py.test, etc
as per setup.py/tox.ini) and executing ${PYTHON_CMD} -m pytest or ${PYTHON_CMD}
setup.py test if supported. It's OK if not all test dependencies have been
ported yet, just add the ones that have, adding comments for the ones that
havent.
- setuptools appears (in setup.py) as an install_requires (RUN_DEPENDS) not a
setup_requires (BUILD_DEPENDS) as in the patch. I don't know why its explicitly
in install_requires though.
- Add LICENSE_FILE=${WRKSRC}/path/to/license when one exists in the
distribution file
- netifaces/netaddr don't appear as setup.py (compulsory) or tox.ini
(potentially optional) dependencies. Can you elaborate on their source and
function?

If possible (highly desirable/recommended), please provide as an attachment the
results of the package test suite as well.

For more information on creating ports for Python packages, see:

https://wiki.freebsd.org/Python/PortsPolicy

-- 
You are receiving this mail because:
You are on the CC list for the bug.