[PATCH] lang/python27 -- Fix namespace collision

[Kubilay Kocak]

On 6/19/17 4:31 AM, Steve Kargl wrote:
> On Sun, Jun 18, 2017 at 11:29:05AM -0700, Steve Kargl wrote:
>> Both IEEE-754 2008 and ISO/IEC TS 18661-4 define the half-cycle
>> trignometric functions cospi, sinpi, and tanpi.  When libm (aka
>> math.h) grows support for sinpi(x), lang/python27 has a namespace
>> collision.  The attached patch fixes the problem.
>>

Hi Steve,

Is this issue relevant only for particular (and/or future) FreeBSD
versions ('where libm grows supports for x, y') or independent of base
entirely?

Also, could you open an upstream issue regarding this please, as a
long-term target for all local (Python port) patches is that they are
included upstream.

This also ensures we can document all patches with their relevant
upstream issue/commit references for our future selves and others.

./koobs

> Well, that's inconvenient.  Seems attachments are stripped.
> 
> --- Modules/mathmodule.c.orig	2017-06-18 11:09:05.938222000 -0700
> +++ Modules/mathmodule.c	2017-06-18 11:09:56.248307000 -0700
> @@ -71,7 +71,7 @@
>  static const double sqrtpi = 1.772453850905516027298167483341145182798;
>  
>  static double
> -sinpi(double x)
> +my_sinpi(double x)
>  {
>      double y, r;
>      int n;
> @@ -270,7 +270,7 @@
>         integer. */
>      if (absx > 200.0) {
>          if (x < 0.0) {
> -            return 0.0/sinpi(x);
> +            return 0.0/my_sinpi(x);
>          }
>          else {
>              errno = ERANGE;
> @@ -294,7 +294,7 @@
>      }
>      z = z * lanczos_g / y;
>      if (x < 0.0) {
> -        r = -pi / sinpi(absx) / absx * exp(y) / lanczos_sum(absx);
> +        r = -pi / my_sinpi(absx) / absx * exp(y) / lanczos_sum(absx);
>          r -= z * r;
>          if (absx < 140.0) {
>              r /= pow(y, absx - 0.5);
> @@ -366,7 +366,7 @@
>              (x-0.5)*(log(x+lanczos_g-0.5)-1);
>      }
>      else {
> -        r = log(pi) - log(fabs(sinpi(absx))) - log(absx) -
> +        r = log(pi) - log(fabs(my_sinpi(absx))) - log(absx) -
>              (log(lanczos_sum(absx)) - lanczos_g +
>               (absx-0.5)*(log(absx+lanczos_g-0.5)-1));
>      }
>