svn commit: r448347 - in head/audio: . py-jack py-jack/files

[Kubilay Kocak]

On 8/20/17 3:51 AM, Richard Gallamore wrote:
> Author: ultima
> Date: Sat Aug 19 17:51:20 2017
> New Revision: 448347
> URL: https://svnweb.freebsd.org/changeset/ports/448347
> 
> Log:
>   PyJack is a module written in C which exposes the Jack API to Python.
>   For information about Jack see http://jackit.sourceforge.net. This
>   enables a Python program to connect to and interact with pro-audio
>   applications which use the Jack Audio Server.
>   
>   WWW: https://pypi.python.org/pypi/py-jack
>   
>   PR:		220990
>   Submitted by:	Yuri Victorovich (maintainer)
>   Reviewed by:	matthew (mentor)
>   Approved by:	matthew (mentor)
>   Differential Revision:	https://reviews.freebsd.org/D12079

Hi Richard,

This port is incorrectly named, please rename/move it. [1]

It conflicts with the PyPI package named 'jack' [2]. Additionally, while
upstream refers to it as 'PyJack' in its descriptions, it is also *not*
the PyPI 'pyjack' package [3].

The use of DISTNAME in python ports is often a give-away that the
PORTNAME is incorrect.

Exceptions to the above rule-of-thumb/hint is if the distribution file
is not the same as the package name (a small number of authors do this).

[1] https://wiki.freebsd.org/Python/PortsPolicy
[2] https://pypi.python.org/pypi/jack/
[3] https://pypi.python.org/pypi/pyjack/

> Added:
>   head/audio/py-jack/
>   head/audio/py-jack/Makefile   (contents, props changed)
>   head/audio/py-jack/distinfo   (contents, props changed)
>   head/audio/py-jack/files/
>   head/audio/py-jack/files/patch-pyjack.c   (contents, props changed)
>   head/audio/py-jack/pkg-descr   (contents, props changed)
> Modified:
>   head/audio/Makefile
> 
> Modified: head/audio/Makefile
> ==============================================================================
> --- head/audio/Makefile	Sat Aug 19 17:49:43 2017	(r448346)
> +++ head/audio/Makefile	Sat Aug 19 17:51:20 2017	(r448347)
> @@ -648,6 +648,7 @@
>      SUBDIR += py-gmusicproxy
>      SUBDIR += py-hsaudiotag
>      SUBDIR += py-id3
> +    SUBDIR += py-jack
>      SUBDIR += py-karaoke
>      SUBDIR += py-mad
>      SUBDIR += py-mpd
> 
> Added: head/audio/py-jack/Makefile
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/audio/py-jack/Makefile	Sat Aug 19 17:51:20 2017	(r448347)
> @@ -0,0 +1,31 @@
> +# Created by: Yuri Victorovich <yuri at rawbw.com>
> +# $FreeBSD$
> +
> +PORTNAME=	jack
> +PORTVERSION=	0.5.2
> +CATEGORIES=	audio python
> +MASTER_SITES=	CHEESESHOP
> +PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
> +DISTNAME=	py-${PORTNAME}-${PORTVERSION}
> +
> +MAINTAINER=	yuri at rawbw.com
> +COMMENT=	PyJack is a Python bindings for the Jack Audio Server

Strip 'PyJack is a '

> +LICENSE=	GPLv2
> +
> +LIB_DEPENDS=	libjack.so:audio/jack
> +BUILD_DEPENDS=	${PYTHON_PKGNAMEPREFIX}numpy>0:math/py-numpy
> +
> +USES=		python:-2.7 localbase
> +USE_PYTHON=	distutils autoplist
> +
> +post-patch:
> +	@${REINPLACE_CMD} -e \
> +		's|"/usr/local/|"${LOCALBASE}/|; \
> +		 s|"jack", "dl"|"jack"|; \
> +		 s|os.system.*|pass|' \
> +		${WRKSRC}/setup.py
> +post-install:
> +	@${STRIP_CMD} ${STAGEDIR}${PYTHONPREFIX_SITELIBDIR}/jack.so
> +
> +.include <bsd.port.mk>
> 
> Added: head/audio/py-jack/distinfo
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/audio/py-jack/distinfo	Sat Aug 19 17:51:20 2017	(r448347)
> @@ -0,0 +1,3 @@
> +TIMESTAMP = 1500938413
> +SHA256 (py-jack-0.5.2.tar.gz) = 67951f7b78ded52f3191a5267cd917f1270a6abe28341ccb3575bdd482488590
> +SIZE (py-jack-0.5.2.tar.gz) = 13490
> 
> Added: head/audio/py-jack/files/patch-pyjack.c
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/audio/py-jack/files/patch-pyjack.c	Sat Aug 19 17:51:20 2017	(r448347)
> @@ -0,0 +1,10 @@
> +--- pyjack.c.orig	2017-07-24 23:24:04 UTC
> ++++ pyjack.c
> +@@ -40,7 +40,6 @@ TODO's:
> + // Global shared data for jack
> + 
> + /* Uncomment the next line if you have Jack2 */
> +-#define JACK2 1
> + 
> + 
> + #define PYJACK_MAX_PORTS 256
> 
> Added: head/audio/py-jack/pkg-descr
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/audio/py-jack/pkg-descr	Sat Aug 19 17:51:20 2017	(r448347)
> @@ -0,0 +1,6 @@
> +PyJack is a module written in C which exposes the Jack API to Python.
> +For information about Jack see http://jackit.sourceforge.net. This
> +enables a Python program to connect to and interact with pro-audio
> +applications which use the Jack Audio Server.
> +
> +WWW: https://pypi.python.org/pypi/py-jack
>