svn commit: r408523 - in head/devel: . py-should_dsl

[Kubilay Kocak]

On 9/02/2016 5:42 PM, Don Lewis wrote:
> On  9 Feb, Kubilay Kocak wrote:
>> On 9/02/2016 12:37 PM, Don Lewis wrote:
>>> Author: truckman
>>> Date: Tue Feb  9 01:37:03 2016
>>> New Revision: 408523
>>> URL: https://svnweb.freebsd.org/changeset/ports/408523
>>>
>>> Log:
>>>   Add py-should_dsl port:
>>>   
>>>     Should assertions in Python as clear and readable as possible
>>>   
>>>     The goal of Should-DSL is to write should expectations in Python
>>>     as clear and readable as possible, using "almost" natural language
>>>     (limited - sometimes - by the Python language constraints).
>>>   
>>>   Sponsored by:	Farsight Security, Inc.
>>>
>>> Added:
>>>   head/devel/py-should_dsl/
>>>   head/devel/py-should_dsl/Makefile   (contents, props changed)
>>>   head/devel/py-should_dsl/distinfo   (contents, props changed)
>>>   head/devel/py-should_dsl/pkg-descr   (contents, props changed)
>>> Modified:
>>>   head/devel/Makefile
>>>
>>> Modified: head/devel/Makefile
>>> ==============================================================================
>>> --- head/devel/Makefile	Tue Feb  9 01:34:41 2016	(r408522)
>>> +++ head/devel/Makefile	Tue Feb  9 01:37:03 2016	(r408523)
>>> @@ -4340,6 +4340,7 @@
>>>      SUBDIR += py-setuptools_hg
>>>      SUBDIR += py-setuptools_scm
>>>      SUBDIR += py-sh
>>> +    SUBDIR += py-should_dsl
>>>      SUBDIR += py-shapely
>>>      SUBDIR += py-simplegeneric
>>>      SUBDIR += py-simplejson
>>>
>>> Added: head/devel/py-should_dsl/Makefile
>>> ==============================================================================
>>> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
>>> +++ head/devel/py-should_dsl/Makefile	Tue Feb  9 01:37:03 2016	(r408523)
>>> @@ -0,0 +1,19 @@
>>> +# $FreeBSD$
>>> +
>>> +PORTNAME=	should_dsl
>>> +PORTVERSION=	2.1.2
>>> +CATEGORIES=	devel python
>>> +MASTER_SITES=	CHEESESHOP
>>> +PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
>>> +
>>> +MAINTAINER=	truckman at FreeBSD.org
>>> +COMMENT=	Should assertions in Python as clear and readable as possible
>>> +
>>> +LICENSE=	MIT
>>> +LICENSE_FILE=	${WRKSRC}/LICENSE
>>> +
>>> +NO_ARCH=	yes
>>> +USES=		python
>>
>> Since the last update of this package was in 2012 and the trove
>> classifiers in the PyPI only specify "up to 3.2":
>>
>> Programming Language :: Python
>> Programming Language :: Python :: 2
>> Programming Language :: Python :: 2.4
>> Programming Language :: Python :: 2.5
>> Programming Language :: Python :: 2.6
>> Programming Language :: Python :: 3
>> Programming Language :: Python :: 3.2
>>
>> .. it's probably worth limiting this to :-3.2 (if not :-2.7) unless it
>> explicitly passes runtime and unit tests (if it has them) on all 3.x
>> versions.
> 
> It definitely seems to work with 2.7.  It doesn't have any unit tests.

I'd go with -3.2 (default to what upstream says( until it can be tested
for all 3.x versions. Shame about the lack of tests, these are super
handy in these situations
> 
>> For all Python porters:
>>
>> Use of USES=python should be limited to those cases where *all or any*
>> python versions are explicitly declared, supported and tested, whether
>> those versions are in the tree as lang/pythonXY ports or not.
>>
>> TLDR: When it comes to declaring dependencies in general, and python
>> version dependencies in particular:
>>
>> Explicit > Implicit (PEP20)
>> Declarative > Imperative
>>
>>> +USE_PYTHON=	distutils autoplist
>>> +
>>> +.include <bsd.port.mk>
>>>
>>> Added: head/devel/py-should_dsl/distinfo
>>> ==============================================================================
>>> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
>>> +++ head/devel/py-should_dsl/distinfo	Tue Feb  9 01:37:03 2016	(r408523)
>>> @@ -0,0 +1,2 @@
>>> +SHA256 (should_dsl-2.1.2.tar.gz) = 36f753d90fbdf84ef2b7a9e07813e3efac725376feb7a793549f3fff7a03232a
>>> +SIZE (should_dsl-2.1.2.tar.gz) = 13650
>>>
>>> Added: head/devel/py-should_dsl/pkg-descr
>>> ==============================================================================
>>> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
>>> +++ head/devel/py-should_dsl/pkg-descr	Tue Feb  9 01:37:03 2016	(r408523)
>>> @@ -0,0 +1,3 @@
>>> +Should assertions in Python as clear and readable as possible
>>> +
>>> +WWW: https://pypi.python.org/pypi/should_dsl
>>
>> Minor nit: PyPI packages pkg-descr WWW: URL should match that in the
>> setup.py:homepage (or url) field:
>>
>> http://www.should-dsl.info
> 
> It looks like that domain has changed hands ...

Gah! :)

Carry on!