[Differential] [Requested Changes To] D2600: [new port] devel/py-pytest-timeout
koobs (Kubilay Kocak)
phabric-noreply at FreeBSD.org
Thu May 21 02:05:11 UTC 2015
koobs requested changes to this revision.
koobs added a comment.
This revision now requires changes to proceed.
Additional to inline comments, does the port also pass poudriere and portlint -AC (with DEVELOPER=yes enabled in /etc/make.conf) ?
INLINE COMMENTS
devel/py-pytest-timeout/Makefile:16 Upstream install_requires (setup.py) field says:
```
install_requires=['pytest>=2.6.3.dev3'],
```
I would change this entry to
```
pytest>=2.6.4
```
which is the current Ports version of py-pytest
devel/py-pytest-timeout/pkg-descr:1 Upstream long_description (setup.py) contains:
```
This is a plugin which will terminate tests after a certain timeout.
When doing so it will show a stack dump of all threads running at the
time. This is useful when running tests under a continuous integration
server or simply if you don't know why the test suite hangs.
```
This seems like a more complete/meaningful description than just a copy of COMMENT from Makefile
devel/py-pytest-timeout/pkg-descr:3 Upstream URL (setup.py) field contains:
```
https://bitbucket.org/flub/pytest-timeout
```
REPOSITORY
rP FreeBSD ports repository
REVISION DETAIL
https://reviews.freebsd.org/D2600
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: loader, koobs
Cc: freebsd-python
More information about the freebsd-python
mailing list