[Bug 199838] [NEW PORT] games/pyfa fitting tool for EVE Online

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199838

Dmitry Marakasov <amdmi3 at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|freebsd-ports-bugs at FreeBSD. |amdmi3 at FreeBSD.org
                   |org                         |
                 CC|                            |amdmi3 at FreeBSD.org
             Status|New                         |In Progress

--- Comment #2 from Dmitry Marakasov <amdmi3 at FreeBSD.org> ---
- GH_COMMIT is deprecated and no longer needed. You should omit GH_COMMIT,
GH_TAGNAME and WRKSRC and add DISTVERSIONSUFFIX=v, this way it'll fetch
v${PORTVERSION} tag
- You should use COPYTREE_SHARE instead of manual find's
- Only uppercase option names are allowed
- Option description is misleading, should probably be reworded
- It seems to be a bad idea to stick data files into PYTHON_SITELIBDIR. You may
use default DATADIR and set PYTHONPATH in the wrapper script
- Wrapper script creating fits more into post-build
- do-install and post-install may be merged, there's not need to split them
- compileall is usually called twice, second time with -O arg to generate
*.pyo. Propaply this port should do the same
- Since plist is quite large, it's better to use PORTDATA=* and omit
%%DATADIR%%* from plist - DATADIR contents will be added automatically this way

-- 
You are receiving this mail because:
You are on the CC list for the bug.