python waf bypasses _MAKE_JOBS number

[Sean Bruno]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 01/09/15 16:29, Marcus von Appen wrote:
> Sean Bruno <sbruno at ignoranthack.me>:
> 
>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
>> 
>> On 01/09/15 11:10, Antoine Brodin wrote:
>>> On Fri, Jan 9, 2015 at 5:52 PM, Sean Bruno
>>> <sbruno at ignoranthack.me> wrote:
>>>> Marcus:
>>>> 
>>>> The thing that I would like "fixed" is python waf ignoring
>>>> the fact that it should not try and detect the number of CPUs
>>>> on the system.
>>>> 
>>> 
>>> Let me rephrase the problem,  there are some problems in some 
>>> individual ports using waf. Those ports do not respect 
>>> ${MAKE_JOBS_NUMBER},  especially when MAKE_JOBS_NUMBER=1. This 
>>> breaks qemu which is not multi job friendly  (people using
>>> qemu have DISABLE_MAKE_JOBS=yes which sets MAKE_JOBS_NUMBER to
>>> 1).
>>> 
>>> Cheers,
>>> 
>>> Antoine
>>> 
>> 
>> YES.  :-)  Sorry for the confusion.
> 
> Just to be a bit more specific: we are not talking about a waf
> port, but about some (still unknown) waf scripts in the upstream
> package, correct? Since this is the usual way, waf is used. Please
> point us to the correct scripts/call hierarchy/whatever that allows
> us to investigate, what the port actually does at the build phase.
> 
> waf issues usually need to be fixed (since it's somewhat similar
> to a cmake, scons or autotools configuration/build file) on the
> problematic port or via injection, hence we need the information
> about how the build is done or at least a pointer, where to look
> at.
> 
> I'm leaving the threading issue aside here, since (for now) there
> is not enough information (for me) to address this. Let's get the
> build issue sorted out first, then take a look at Python's
> threading support for non-amd64 and non-i386 platforms on FreeBSD.
> 
> Cheers Marcus
> 
> 

The most obvious 2 ports that we've been fighting with are
databases/tdb and devel/talloc

They have some Makefile instructions that manifest this issue.

Specifically:

     74 .if !defined(DISABLE_MAKE_JOBS) && !defined(MAKE_JOBS_UNSAFE)
     75 CONFIGURE_ARGS+=        --jobs=${MAKE_JOBS_NUMBER}
     76 _MAKE_JOBS+=            --jobs=${MAKE_JOBS_NUMBER}
     77 .else
     78 CONFIGURE_ARGS+=        --jobs=1
     79 _MAKE_JOBS+=            --jobs=1
     80 .endif

sean
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQF8BAEBCgBmBQJUsHAlXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRCQUFENDYzMkU3MTIxREU4RDIwOTk3REQx
MjAxRUZDQTFFNzI3RTY0AAoJEBIB78oecn5kA4EH/2LS9xhdeAvFm7fsBqsywB99
8rJIOK//c4ZdoBA+OwbTvIAAaIB6tSGrtLp5jJ5Ae15E9/unYcoleLmk3nBci0Wa
155v/oD8YO/cYA8MuKcGCuKFiHAQoggEKDfI8prosL2dGeZw+C+hZOxi6/92JHY3
oc0G8BC4hosuZA4oT0aAdmX6tX3kzCCRuli9c1luW9in5Vdn6ifuiToKSpK15k/W
u7+BKFQQFi6766ahIDTEoQAKofVm9M8SWJZG2HmfGanChEACV+T7I/Xxcw5ygSfK
vGwevvtJcLwUqQuFFLcTxhk8JQkeCt41lRwgTUDCEsoMlielO1U0QO0h6YnHw4c=
=d8Ie
-----END PGP SIGNATURE-----