[Bug 193313] [NEW PORT] www/py-wsgidav: wsgi implemented DAV

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193313

Kubilay Kocak <koobs at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |needs-qa

--- Comment #8 from Kubilay Kocak <koobs at FreeBSD.org> ---
(In reply to Jingfeng Yan from comment #4)
> (In reply to Kubilay Kocak from comment #3)
> > Thanks for your submission Jingfeng.
> Thank you for your reviewing.  

You're welcome

> > Additional review items:
> > 
> >  * LICENSE_FILE is missing
> LICENSE_FILE seems not to be mandatory and some py modules do not have full
> text of license.  For example, zope213...  The only LICENSE info only be
> carried in PKG-INFO file.

Include it if the distribution files contain a standalone license file. If not
that's fine

> >  * Is there a reason the tests directory cant remain?
> Some of python modules have test directory. When install, it first detects
> __init__.py exists in the tests directory (some other modules have installed
> tests).  The other thing that I don't understand well, all the python
> modules'  tests directory install to the same location, and is there any way
> to avoid name conflict?  
> __init__.py is place holder in most of cases (but it could do something,
> too).  How about other file names.  If there is better way to keep the tests
> directory, I will follow. 

Certainly clean up if the python package installs conflicting files. It's
prudent to create issue reports for these things upstream, so that authors can
learn to improve their packaging methods, and we can also leverage test
functionality.

One last thing, 

When you're providing updates to previous submitted attachments, remove all
attachments except for the latest (and complete) versions you want to be
reviewed and committed. 

The diff of the last requested changes is not needed, only the latest version.

-- 
You are receiving this mail because:
You are the assignee for the bug.