[Bug 193313] [NEW PORT] www/py-wsgidav: wsgi implemented DAV

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193313

--- Comment #4 from Jingfeng Yan <yan_jingfeng at yahoo.com> ---
(In reply to Kubilay Kocak from comment #3)
> Thanks for your submission Jingfeng.
Thank you for your reviewing.  

> 
> A quick note that the following entries have been deprecated [1]
> 
>  * USE_PYTHON= 2
>  * USE_PYDISTUTILS= yes
>  * PYDISTUTILS_AUTOPLIST=  yes
> 
> [1] See /Mk/Uses/python.mk for more information
> [2] Add DEVELOPER=yes to your make.conf to enable additional QA checks
> 
Fully accepted.  Will update the port shar file in one or two minutes. 

> Additional review items:
> 
>  * LICENSE_FILE is missing
LICENSE_FILE seems not to be mandatory and some py modules do not have full
text of license.  For example, zope213...  The only LICENSE info only be
carried in PKG-INFO file.

>  * You can use CHEESESHOP for MASTER_SITES which sets MASTER_SITE_SUBDIR
Good learning, it makes life easier.  I did struggle with upper/lowercase of
MASTER_SITE_SUBDIR when I ported. 

>  * Is there a reason the tests directory cant remain?
Some of python modules have test directory. When install, it first detects
__init__.py exists in the tests directory (some other modules have installed
tests).  The other thing that I don't understand well, all the python modules' 
tests directory install to the same location, and is there any way to avoid
name conflict?  
__init__.py is place holder in most of cases (but it could do something, too). 
How about other file names.  If there is better way to keep the tests
directory, I will follow. 

>  * Attach portlint -AC output :)
will do.

> 
> Feel free to update your attachment with those changes, and you may also use
> svn diff to assist review by our committers
no svn diff, but diff this time.  Will do in the future.

-- 
You are receiving this mail because:
You are the assignee for the bug.