Wrong python_CMD in shebangfix?

[Marcus von Appen]

On, Wed May 14, 2014, Dmitry Sivachenko wrote:

> Hello!
>
> Imagine that I have python-2 as default version, so that /usr/local/bin/python points to python2.7
> And I have a port which USE_PYTHON=3 and USES=shebangfix.
>
> It will "fix" python path as "/usr/local/bin/python" which is wrong (it should point to python3).
>

The path is not *wrong*. lang/python installs /usr/local/bin/python.

> I propose the following patch:
> --- shebangfix.mk.orig  2014-03-15 14:31:54.000000000 +0400
> +++ shebangfix.mk       2014-05-14 21:08:37.000000000 +0400
> @@ -38,7 +38,7 @@
>  php_OLD_CMD?=  /usr/bin/php
>  php_CMD?=      ${LOCALBASE}/bin/php
>  python_OLD_CMD?=       /usr/bin/python
> -python_CMD?=   ${LOCALBASE}/bin/python
> +python_CMD?=   ${PYTHON_CMD}
>  ruby_OLD_CMD?= /usr/bin/ruby
>  ruby_CMD?=     ${LOCALBASE}/bin/ruby
>  tcl_OLD_CMD?=  /usr/bin/tclsh
>
>
> What do you think?

Using ${PYTHON_CMD} would save maintainers overriding python_CMD again and
again for many ports.


Cheers
Marcus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-python/attachments/20140515/353a9f67/attachment.sig>