[Bug 233693] [PowerPC64] Powerd unable to change cpu frequency

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sat Dec 1 21:38:18 UTC 2018


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233693

--- Comment #10 from commit-hook at freebsd.org ---
A commit references this bug:

Author: cem
Date: Sat Dec  1 21:37:47 UTC 2018
New revision: 341389
URL: https://svnweb.freebsd.org/changeset/base/341389

Log:
  pmcr: Fix pstate setting on Power8

  Fix p-state setting on Power8 by removing the accidental double-indirection
of
  the pstate_ids table.

  The pstate_ids table comes from the OF property "ibm,pstate-ids."  On Power9,
  the values happen to be identical to the indices, so the extra indirection
was
  harmless.  On Power8, the values were out of the range [0, npstates], so
  pmcr_set() would fail the spec[0] range check with EINVAL.

  While here, include both the value and index in the driver-specific register
  array as spec[0] and spec[1] respectively.  They're redundant, but relatively
  harmless, and it may aid debugging.

  While here, fix the range check to exclude the index npstates, which is one
  past the last valid index.

  PR:           233693
  Reported and tested by:       sbruno
  Reviewed by:  jhibbits

Changes:
  head/sys/powerpc/cpufreq/pmcr.c

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the freebsd-ppc mailing list