svn commit: r313005 - in head/sys: conf modules/zfs [The related 215947: -mlongcall use instead of -mminimal-toc]

[Mark Millard]

On 2017-Jan-31, at 6:44 PM, Justin Hibbits <chmeeedalf at gmail.com> wrote:

> On Jan 31, 2017, at 4:26 AM, Mark Millard wrote:
>>> Modified: head/sys/modules/zfs/Makefile
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =
>>> =====================================================================
>>> --- head/sys/modules/zfs/Makefile	Tue Jan 31 01:48:55 2017	(r313004)
>>> +++ head/sys/modules/zfs/Makefile	Tue Jan 31 01:55:29 2017	(r313005)
>>> @@ -94,7 +94,7 @@ CFLAGS+=-I${SUNW}/common
>>> CFLAGS+=-DBUILDING_ZFS
>>> 
>>> .if ${MACHINE_ARCH} == "powerpc64"
>>> -CFLAGS+=-mminimal-toc
>>> +CFLAGS.gcc+=-mminimal-toc
>>> .endif
>>> 
>>> .ifdef ZFS_DEBUG
>> 
>> You may want to process my bugzilla 215107 with head/sys/modules/zfs/Makefile
>> as it also deals with that -mminimal-toc: in other words to declare 215107
>> fixed by this update.
>> 
>> ===
>> Mark Millard
>> markmi at dsl-only.net
>> 
> 
> Ah, thanks for reminding me, I'll take that.
> 
> - Justin

Thanks.

215947 is sort of related in that it eliminated -mlongcall
usage because (A) clang 3.8.0 did not have it and (B)
the usage was not needed under the medium model. It also
limited the forced use of gcc in:

/usr/src/lib/csu/powerpc64/Makefile

But I've had the patch in use for a long time and -mlongcall
now exists if one requires a recent enough clang. (I only
recently made a bugzilla for the issue so bugzilla does
not reflect the patch's age.)

Even if you leave in the -mlongcall usage something
like part of the patch should be applied to avoid forcing
gcc use.

And the comment about why -mlongcall is needed is now wrong
even if the -mlongcall 's are left in place.

===
Mark Millard
markmi at dsl-only.net