RFC: OpenPIC IPI patch
Marcel Moolenaar
marcel at xcllnt.net
Wed May 30 20:37:06 UTC 2012
On May 30, 2012, at 1:13 PM, Rafal Jaworowski wrote:
> Can you please have a look at this patch and let us know about any comments / objections? We identified a problem with IPI on the recent FSL eOpenPIC, description in the patch:
>
> http://people.freebsd.org/~raj/patches/powerpc/openpic.diff
Looks good. Please consider adding some checks to openpic_ipi() where
we peek into the cpuset_t type and access the "bits". An assert would
be nice if the set contains cpus number 32 or up. This to make it
painfully obvious that it's time to extend openpic_ipi() to handle more
than 32 CPUs if and when the need arises.
FYI,
--
Marcel Moolenaar
marcel at xcllnt.net
More information about the freebsd-ppc
mailing list