Port build failure in stage-qa

[Stefan Esser]

Building virtualbox-ose-kmod failed for me today (for the first time)
due to REINPLACE_CMD not changing some files. This breaks my kernel
build that include the kernel modules:

====> Compressing man pages (compress-man)
===> Staging rc.d startup script(s)
====> Running Q/A tests (stage-qa)
Warning: Possible REINPLACE_CMD issues:
- - REINPLACE_CMD ran, but did not modify file contents: Config.kmk
- - REINPLACE_CMD ran, but did not modify file contents: configure
*** Error code 1

Stop.
make[1]: stopped in /usr/svn/ports/head/emulators/virtualbox-ose-kmod
*** Error code 1

Stop.
make: stopped in /usr/svn/ports/head/emulators/virtualbox-ose-kmod



This appears to be due to the following commit that affected qa.sh:

r554893 | mat | 2020-11-11 14:29:52 +0100 (Wed, 11 Nov 2020) | 13 lines

Add set pipefail in most framework scripts.

set pipefail changes the pipeline return status from being the return
status of the last command to the last non 0 exit status of any command
in the pipeline.  This is needed to make sure all the commands in a
pipeline did actually return a non 0 status and not only the last one.

PR:             250723
Exp-run by:     antoine
Reviewed by:    bapt
Approved by:    bapt
Differential Revision:  https://reviews.freebsd.org/D27007


Since DEVELOPER=yes cannot be overridden on the command line, I'll
have to remove it from make.conf to get a kernel with matching
modules installed.

Is this an expected outcome of the change?

Regards, STefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20201111/c90eb1ba/attachment.sig>