patch to bsd.ports.mk to support out-of-tree patches.

Marcus von Appen mva at freebsd.org
Tue Mar 24 10:39:11 UTC 2015


Julian Elischer <julian at freebsd.org>:

[...]
>          esac | ${PATCH} ${PATCH_DIST_ARGS} `patch_dist_strip $$i` ; \
>      done )
>  .endif
> +.if defined(EXTRA_PATCH_TREE)
[...]
> +.endif
>  .if defined(EXTRA_PATCHES)
>      @set -e ; \
>      for i in ${EXTRA_PATCHES}; do \
>
>
> ============

Nice. I'd however change the patch behaviour to the following:

- patch-* from FreeBSD
- EXTRA_PATCHES from FreeBSD
- local patches

Your patch looks like it appleis the out-of-tree patches prior
to any EXTRA_PATCHES defined by the port itself. This should not be
the case, in my opinion. Locally managed patches should always come
last to ensure that all FreeBSD/maintainer-specific bits have been
applied and the local changes are just added on top of those.

Cheers
Marcus




More information about the freebsd-ports mailing list