Glassfish port update (Bug 194097)

[Enrico Maria Crisostomo]

Thank you very much Kevin, and thanks for the clarification about the maintainer approval.

I read about poudriere in the Porter’s guide but seemed overkill to me for the simple port I was updating. However, if that speeds things up, I’ll manage to setup a FreeBSD VM with poudriere for ports development.

Cheers,
-- 
Enrico Maria Crisostomo

On 14 Oct 2014 at 20:23:12, Kevin Oberman (rkoberman at gmail.com) wrote:

On Tue, Oct 14, 2014 at 4:22 AM, Enrico Maria Crisostomo <enrico.m.crisostomo at gmail.com> wrote:
Hi all,

Some days ago I’ve submitted a PR to update the Glassfish port to 4.1, since the existing one is pretty old:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194097

Am I required to do something else or somebody will look at this as it is?

Thanks and regards,
-- 
Enrico Maria Crisostomo

In theory, no. But in reality, if "some days" have passed, you need to bug the maintainer to approve it. Your statement that the maintainer approves is not adequate. He needs to submit the approval himself.

Once he approves it, it is just waiting until a committer has the time to look at it and, if there are no issues, committing it. That will probably move faster if you include the output of a poudiere or redports run in the ticket.
--
R. Kevin Oberman, Network Engineer, Retired
E-mail: rkoberman at gmail.com