Request for (i386) testing: american fuzzy lop

[Fabian Keil]

Jan Beich <jbeich at vfemail.net> wrote:

> Fabian Keil <freebsd-listen at fabiankeil.de> writes:
> 
> >>   [*] Testing the CC wrapper and instrumentation output...
> >>   AFL_QUIET=1 AFL_INST_RATIO=100 AFL_PATH=. ./afl-clang -O2 -pipe
> >> -fstack-protector -fno-strict-aliasing -Wall -D_FORTIFY_SOURCE=2
> >> -Wno-pointer-sign -DAFL_PATH=\"/prefix/afl-0.60b/lib/afl\"
> >> -DDOC_PATH=\"/prefix/afl-0.60b/share/doc/afl\" -DVERSION=\"0.60b\"
> >> -Wno-format test-instr.c -o test-instr
> >>   /tmp/.afl-19244-1416499444.s: Assembler messages:
> >>   /tmp/.afl-19244-1416499444.s:222: Error: unknown pseudo-op: `.cfi_sections'
> >>   clang: error: assembler command failed with exit code 1 (use -v to
> >> see invocation)
> >
> > I updated the port to (hopefully) use as from ports on i386:
> > http://www.fabiankeil.de/sourcecode/freebsd/afl-61b.shar
> >
> > Does this make a difference?
> 
> Maybe, if you want to force devel/binutils on 9.x users. It'd be nice to
> debug why clang misbehaves. Anyway, this version has wrong checksum.
> 
>   => afl-0.61b.tgz doesn't seem to exist in /portdistfiles/.
>   => Attempting to fetch http://lcamtuf.coredump.cx/afl/releases/afl-0.61b.tgz
>   fetch: http://lcamtuf.coredump.cx/afl/releases/afl-0.61b.tgz: size mismatch: expected 678088, actual 678234

The tarball got re-rolled ...

> After fixing I've tested on 11.0C i386, 10.1R i386, 10.0R amd64, 9.3R i386,
> 9.1R i386, 8.4R amd64 + tainted host on 11.0C amd64. For one, 8.x exhibit 
> another old GNU as(1) issue:
> 
>   [*] Testing the CC wrapper and instrumentation output...
>   AFL_QUIET=1 AFL_INST_RATIO=100 AFL_PATH=. ./afl-gcc -O2 -pipe -fstack-protector -fno-strict-aliasing -Wall -D_FORTIFY_SOURCE=2 -Wno-pointer-sign -DAFL_PATH=\"/prefix/afl-0.61b/lib/afl\" -DDOC_PATH=\"/prefix/afl-0.61b/share/doc/afl\" -DVERSION=\"0.61b\" -Wno-format test-instr.c -o test-instr
>   /tmp/.afl-16870-1416574405.s: Assembler messages:
>   /tmp/.afl-16870-1416574405.s:572: Error: suffix or operands invalid for `lahf'
>   /tmp/.afl-16870-1416574405.s:593: Error: suffix or operands invalid for `sahf'
>   Makefile:65: recipe for target 'test_build' failed
> 
> > +.if ${ARCH} == "i386"
> > +BUILD_DEPENDS +=	${LOCALBASE}/bin/as:${PORTSDIR}/devel/binutils
> > +.endif
> [...]
> > +.if ${ARCH} == "i386"
> > +	${REINPLACE_CMD} -e 's@\(  as_params\[0\] = "\)@\1${LOCALBASE}/bin/@' \
> > +		${WRKSRC}/afl-as.c
> > +.endif
> 
> If ${LOCALBASE}/bin/as maybe called after install then you have to
> adjust RUN_DEPENDS. Keep in mind package-only users.

Indeed.

> >
> > If not, I'll probably just submit the port marked as broken
> > for i386 and try to get this working later on.

> A passing by committer may also complain about PORTVERSION vs. DISTVERSION,
> lack of LICENSE and DATADIR in pkg-plist.

I'm aware of the last two potential complaints and am prepared to
deal with them, but I'm not sure I understand the first one.

Are you suggesting that using DISTVERSION instead of PORTVERSION would
be more appropriate? At least from the comments in bsd.port.mk that's
not obvious to me.

> diff --git security/afl/Makefile security/afl/Makefile
> index e197507..db31853 100644
> --- security/afl/Makefile
> +++ security/afl/Makefile

Thanks a lot for the patch, I updated the shar file and will submit it
tomorrow provided the tarball doesn't get re-rolled again.

Fabian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20141121/def3759e/attachment.sig>