Adventures in ports, chapter 346785

[George Mitchell]

On 03/05/14 03:30, René Ladan wrote:
> On 03/05/2014 01:45, George Mitchell wrote:
>> On 03/04/14 13:28, René Ladan wrote:
>>> 2014-03-04 12:29 GMT+01:00 George Mitchell <george+freebsd at m5p.com
>>> <mailto:george+freebsd at m5p.com>>:
>>>
>>>      Couldn't compile chromium without attached patch on FreeBSD 8.4.
>>>
>>>
>>> I committed a slightly different version of your patch in r347055, can
>>> you retry?
>>>
>>> René
>>>
>> Thanks for your help, but this doesn't seem to fix the compile errors
>> in content/browser/browser_shutdown_profile_dumper.cc,
>> testing/perf/perf_test.cc, or ui/gfx/codec/jpeg_codec.cc that were
>> caused by the absence or misordering of stdio.h.           -- George
>>
> Hmm, I did add the patch for
> content/browser/browser_shutdown_profile_dumper.cc as a conditional
> patch when using GCC (i.e. in files/extra-patch-gcc).

You are right, I didn't get the FILE error in that file.  Sorry for
typing my reply too quickly.

> I indeed forgot to add the other two patches which I added to
> files/extra-patch-gcc too (having to place stdio.h before <thisfile>.h
> looks fishy, but that's another story).
>
>>From what I see on my virtual 8.4 box, chromium should choose GCC 4.7+
> as compiler (and clang on 10.0).
>
> To be really sure, what is the output of 'make -V CHOSEN_COMPILER_TYPE'
> on your box?
>
> René
>

sullivan.m5p.com.1) uname -a
FreeBSD sullivan.m5p.com 8.4-STABLE FreeBSD 8.4-STABLE #0 r254883: Sun 
Aug 25 15:52:19 EDT 2013 
george at sullivan.m5p.com:/usr/obj/usr/src/sys/M5P  amd64
sullivan.m5p.com.2) make -V CHOSEN_COMPILER_TYPE

sullivan.m5p.com.3) cat /etc/src.conf
cat: /etc/src.conf: No such file or directory
sullivan.m5p.com.4) cat /etc/make.conf
WITH_PKGNG=yes
DISABLE_VULNERABILITIES=yes
WITH_NEW_XORG=yes

-- George