HEADS UP: Berkeley DB 4...4.7 port removals/upgrades may require manual preparation

[Michael Gmelin]

On Sun, 24 Aug 2014 15:36:18 +0200
Michael Gmelin <grembo at freebsd.org> wrote:

> On Sun, 24 Aug 2014 15:08:07 +0200
> olli hauer <ohauer at gmx.de> wrote:
> 
> > On 2014-08-24 14:37, Michael Gmelin wrote:
> > > 
> > > 
> > > On Sun, 24 Aug 2014 14:30:06 +0200
> > > Kurt Jaeger <lists at opsec.eu> wrote:
> > > 
> > >> Hi!
> > >>
> > >>>> Hm, using USE_BDB=$numble looks wrong to me in devel/ice.
> > >>>>
> > >>>> Can you test the following patch.
> > >>>>
> > >>>> Index: Makefile
> > >>>> ===================================================================
> > >>>> --- devel/ice/Makefile    (revision 365910)
> > >>>> +++ devel/ice/Makefile    (working copy)
> > >>>> @@ -27,7 +27,8 @@
> > >>>>  .endif
> > >>>>
> > >>>>  USES=                  iconv gmake
> > >>>> -USE_BDB=               5
> > >>>> +USE_BDB=               yes
> > >>>> +WANT_BDB_VER=          5
> > >>>>  INVALID_BDB_VER=       40 41 42 43 44 46 47 48 6
> > >>>>  USE_LDCONFIG=          yes
> > >>>>  BUILD_WRKSRC?=         ${WRKSRC}/cpp
> > >>
> > >>> @Kurt: Could you test and confirm? If this works, I'll commit
> > >>> the patch.
> > >>
> > >> Yes, it builds.
> > >>
> > > 
> > > I created a commit request
> > > 
> > > https://reviews.freebsd.org/D679
> > > 
> > 
> > Kurt, or you can commit this even w.o. PR.
> > The patch does not break anything but allows the port to build as
> > required. I assume there are even more easter eggs in the tree,
> > specially for USE_BDB.
> > 

@Kurt: I assume you have WITH_BDB_VER= 6 in your make.conf?

> 
> A short grep shows that the following ports are affected, the question
> is if simply converting them to
> 
> USE_BDB=	yes
> WANT_BDB_VER=	<prior value of USE_BDB>
> 
> is the right thing to do.
> 

To answer my own question: Probably not, as it seems legal to use
USE_BDB= <version>, which *should* (or at least used to) have the same
effect as

USE_BDB= yes
WITH_BDB_VER= <version>

I'm a bit curious what the correct use of INVALID_BDB_VER is, since it
seems incompatible with using WITH_BDB_VER in make.conf, so in the end
a port always has to specify WANT_BDB_VER if you want to ensure it
builds correctly.

Also, using INVALID_BDB_VER in devel/ice seems redundant now:

USE_BDB= yes
WANT_BDB_VER= 5
INVALID_BDB_VER=       40 41 42 43 44 46 47 48 6

I assume that

USE_BDB= yes
WANT_BDB_VER= 5

will accomplish the same.

- Michael

-- 
Michael Gmelin