libiconv problem on dansguardian-(devel)

[Renato Botelho]

On 17-10-2013 10:02, Boris Samorodov wrote:
> 17.10.2013 16:56, Renato Botelho пишет:
>> On 17-10-2013 09:38, Boris Samorodov wrote:
>>> 17.10.2013 15:19, Marko Cupać пишет:
>>>
>>>> I cannot compile either of the two with NTLM option enabled:
>>>> www/dansguardian
>>>> www/dansguardian-devel
>>>>
>>>> This is on 9.2-RELEASE i386.
>>>>
>>>> Both fail with the same error message:
>>>>
>>>> ---- error message ----
>>>> checking for NTLM support... yes
>>>> checking for iconv... no
>>>> no
>>>> checking for iconv in -liconv... no
>>>> no
>>>> checking for libiconv in -liconv... no
>>>> configure: error: no native or standard library iconv function found! (needed by NTLM plugin - try again with "--with-libiconv"?)
>>>> ===>  Script "configure" failed unexpectedly.
>>>> ---- error message ----
>>>>
>>>> Any idea how to fix this?
>>>
>>> I think that the right way is to include iconv to Uses unconditionally
>>> (keeping in mind that --with-libiconv=${LOCALBASE} also was used
>>> unconditionally before switching to Uses/iconv.mk). The same for
>>> www/dansguardian-devel.
>>>
>>> The proposed patch attached.
>>
>> Thanks Boris, feel free to commit it please.
> 
> Ok, I have a question though. Should a PORTREVISION be bumped?
> The package for 11-x and 10-x won't change, however for 9.x and 8.x
> would. I assume that to be on a safe side it's better to bump it.
> What do you think? Thanks!

I agree with bumping, sounds more safe.

-- 
Renato Botelho <garga     @ FreeBSD.org>
               <garga.bsd @ gmail.com>
GnuPG Key: http://www.FreeBSD.org/~garga/pubkey.asc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 941 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20131017/54eb9c06/attachment.sig>