FreeBSD apcupsd port - patch for APC 9606 SNMP cards

[Birch Zimmer]

Hello again,

Back when I last wrote I had submitted the patch request to the apcupsd 
project using their recommended procedure of a mailing list post, but 
have not heard any feedback about it yet. Given that the apcupsd project 
has not been much development lately and it has been more than two years 
since their last release, that may be a very slow way for the patch to 
make it's way into the FreeBSD ports tree.

http://sourceforge.net/mailarchive/forum.php?thread_name=BAY147-W26409A36B1611A87DB5D4DC3F50%40phx.gbl&forum_name=apcupsd-users


In the mean time, it would be great to have the patched applied to the 
FreeBSD ports tree. That way those who are using APC 9606 devices on 
their networks will not have to hand patch the source to avoid it 
dumping core on startup. :)

Thanks again,

Birch



birch wrote on 2/19/2013 11:06 AM:
> Sure, I will do that as well.
>
> It looks like not much development has happened since late 2011, so who
> knows when they will push out their next release.
>
> Ion-Mihai Tetcu wrote on 2/19/2013 10:21 AM:
>> I have no problem integrating this patch, but it should be really
>> submitted upstream ...
>>
>> On Tue, 19 Feb 2013 09:16:37 -0800
>> birch <birch at naturalpoint.com> wrote:
>>
>>> Hello again,
>>>
>>> Just did an upgrade to FreeBSD 9.1 and I noticed that the apcupsd
>>> port still has this crash and requires the patch. It would be
>>> fantastic if the patch below could be integrated into the port for
>>> those of us who are using 9606 SNMP cards.
>>>
>>> Also adding a CC to ports at FreeBSD.org in case the email address for
>>> the port maintainer is not being checked.
>>>
>>> Many thanks!
>>>
>>> birch
>>>
>>>
>>>
>>> ---
>>> sysutils/apcupsd/work/apcupsd-3.14.10/src/drivers/snmplite/apc-mib.cpp
>>> +++
>>> sysutils/apcupsd/work/apcupsd-3.14.10/src/drivers/snmplite/apc-mib.cpp
>>> @@ -307,6 +307,8 @@ break;
>>>
>>>       case CI_Overload:
>>> +      if (data.str.len() < 9)
>>> +         break;
>>>          Dmsg1(80, "Got CI_Overload: %c\n", data.str[8]);
>>>          if (data.str[8] == '1')
>>>             ups->set_overload();
>>>
>>>
>>>
>>> birch wrote on 7/19/2012 10:33 AM:
>>>> Hello,
>>>>
>>>> The current version of apcupsd in the ports tree for FreeBSD 8.3 no
>>>> longer works with APC ups's connected via APC 9606 SNMP cards.
>>>> Would it be possible to get the following patch added to the port,
>>>> and/or passed upstream?
>>>>
>>>>
>>>> The link below describes the problem and fix in more detail, I have
>>>> included their patch in this email. I have verified that this patch
>>>> fixes resolves the issue on FreeBSD 8.3 and allows apcupsd to run
>>>> without crashing on startup.
>>>>
>>>>
>>>> Thank you,
>>>> birch
>>>>
>>>> "Debian Bug report logs - #655741"
>>>> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=655741
>>>>
>>>>
>>>> Here is the patch as I tested it :
>>>>
>>>> ---
>>>> sysutils/apcupsd/work/apcupsd-3.14.10/src/drivers/snmplite/apc-mib.cpp
>>>> +++
>>>> sysutils/apcupsd/work/apcupsd-3.14.10/src/drivers/snmplite/apc-mib.cpp
>>>> @@ -307,6 +307,8 @@ break;
>>>>
>>>>       case CI_Overload:
>>>> +      if (data.str.len() < 9)
>>>> +         break;
>>>>          Dmsg1(80, "Got CI_Overload: %c\n", data.str[8]);
>>>>          if (data.str[8] == '1')
>>>>             ups->set_overload();
>>>
>>
>>