firefox build broken under clang 3.3

[Brandon Gooch]

On Fri, Apr 19, 2013 at 1:06 PM, Florian Smeets <flo at smeets.im> wrote:
> On 19.04.13 19:48, Dimitry Andric wrote:
>> On Apr 19, 2013, at 17:56, Florian Smeets <flo at smeets.im> wrote:
>>
>>> On 19.04.13 04:01, kit wrote:
>>>> updated current and now firefox and thunderbird both fail to build under
>>>> the new clang 3.3. has anyone seen this or know how to fix?
>>>
>>> The fix is here:
>>>
>>> http://tb.smeets.im/~flo/gecko-clang33-fixes.diff
>>>
>>> It will be committed after the freeze.
>>
>> Are these fixes from upstream?  If not, it would be nice to send them there...
>>
>>
>
> patch-bug854936 is a workaround because we don't have
> http://llvm.org/viewvc/llvm-project?view=revision&revision=178950 yet.
>
> firefox-nightly (in our gecko svn repo) already compiles fine without
> patch-clang33
>
> So everything should be fine :)
>
> Florian

Thanks for fixing the build issues.

Now, I've built Firefox with Clang, but the darn thing segfaults at
the drop of a hat:

$ gdb /usr/local/bin/firefox firefox.core
...
(gdb) bt
#0  0x00000008011eefaa in thr_kill () from /lib/libc.so.7
#1  0x00000008024d254d in XRE_InstallX11ErrorHandler ()
   from /usr/local/lib/firefox/libxul.so
#2  0x0000000800f74116 in swapcontext () from /lib/libthr.so.3
#3  0x0000000800f73d39 in sigaction () from /lib/libthr.so.3
#4  0x00007ffffffff193 in ?? ()
#5  0x0000000800f73c20 in sigaction () from /lib/libthr.so.3
Previous frame inner to this frame (corrupt stack?)

Rebuilding with debugging symbols provides no further insight, as that
seems to provide a work-around for whatever the root cause may be
(i.e. no more segfaults).

Are any of you seeing something similar?

-Brandon