HAVE_GNOME vs. bsd.ports.options.mk

[Michael Gmelin]

On Wed, 10 Oct 2012 12:25:27 +0200
Baptiste Daroussin <bapt at FreeBSD.org> wrote:

> On Wed, Oct 10, 2012 at 12:18:50PM +0200, Michael Gmelin wrote:
> > Hi
> > 
> > I noticed that HAVE_GNOME doesn't work properly with
> > bsd.ports.options.mk yet, so
> > 
> > .include <bsd.port.options.mk>
> > .if ${HAVE_GNOME:Mgnomelibs}!=""
> > # ...
> > .endif
> > .include <bsd.port.mk>
> > 
> > won't work, while this
> > 
> > .include <bsd.port.pre.mk>
> > .if ${HAVE_GNOME:Mgnomelibs}!=""
> > # ...
> > .endif
> > .include <bsd.port.post.mk>
> > 
> > does.
> > 
> > AFAIK bsd.port.pre.mk/bsd.port.post.mk should be replaced by
> > bsd.port.options.mk/bsd.port.mk in the long term, so having this
> > work or documenting a workaround would help port maintainers who are
> > in the process of updating the port structure.
> > 
> > Michael
> > 
> > -- 
> > Michael Gmelin
> > _______________________________________________
> > freebsd-ports at freebsd.org mailing list
> > http://lists.freebsd.org/mailman/listinfo/freebsd-ports
> > To unsubscribe, send any mail to
> > "freebsd-ports-unsubscribe at freebsd.org"
> 
> Which ports are you speaking about? given that HAVE_GNOME:#gnomelibs
> is refering to gnome 1.4 I think this part can safely be dropped out.
> 
> regards,
> Bapt

I'm talking about the feature in general, it also applies to
HAVE_GNOME:Mesound, HAVE_GNOME:Mpygnomeextras etc.

I stumbled over this while converting polish/gnugadu2 to OptionsNG
(http://www.freebsd.org/cgi/query-pr.cgi?pr=172427).

Michael

-- 
Michael Gmelin