PR ports/164449: update to finance/gnucash timeout
Guido Falsi
mad at madpilot.net
Thu Feb 16 22:26:11 UTC 2012
On 02/16/12 10:15, Chris Rees wrote:
> On 13 February 2012 16:15, Guido Falsi<mad at madpilot.net> wrote:
>> Hello,
>>
>> I'd like to ask if the PR in the subject can be committed due to
>> maintainer timeout.
>
> Teams don't time out as such usually... I've CC'd gnome@ as a gentle poke.
Thanks. I did not really know this. I'll remember this in the future.
>
> Your patch also uses the incorrect test "$var" == "value"; you should
> only use one = sign with test. This will fail on 7.x.
>
Really sorry about this one. It just slipped in.
But...This did not fail on redports 7.x tinderbox:
https://redports.org/~madpilot/20120124141905-52190-7485/gnucash-2.4.9.log
I would have checked this if it did.
Anyway I'll remember to pay more attention in the future.
--
Guido Falsi <mad at madpilot.net>
More information about the freebsd-ports
mailing list