portlint(1) knobs order: let's make things more logical
Chris Rees
crees at freebsd.org
Sun Jun 26 08:22:46 UTC 2011
On 26 Jun 2011 09:16, "Ilya A. Arkhipov" <micro at heavennet.ru> wrote:
>
> 25 июня 2011 г. 15:52 пользователь Ilya A. Arkhipov <micro at heavennet.ru>
написал:
>
>>
>>
>> 25 июня 2011 г. 4:24 пользователь Joe Marcus Clarke <marcus at freebsd.org>
написал:
>>
>>> On 6/24/11 8:16 AM, Ilya A. Arkhipov wrote:
>>> > 23 июня 2011 г. 21:52 пользователь Ilya A. Arkhipov <
micro at heavennet.ru>написал:
>>> >
>>> >> СС: to eitan at eitanadler.com
>>> >
>>> >
>>> > Hi danfe@, marcus@ and all
>>> >
>>> > What you say about this patch(in attach)?
>>> >
>>> > ps. sorry i can't test patch on my work
>>>
>>> Thanks. Can you submit this as a PR so I can track it. I have a
>>> portlint commit coming up soon.
>>>
>>> Joe
>>>
>>> --
>>> Joe Marcus Clarke
>>> FreeBSD GNOME Team :: gnome at FreeBSD.org
>>> FreeNode / #freebsd-gnome
>>> http://www.FreeBSD.org/gnome
>>
>>
>> All patch have error's...
>> if we use "&checkorder('LICENSE', $tmp, $file," that this block
invariable, but there is no license at all.
>> Also if try:
>> print "OK: checking fourth section of $file (LICENSE).\n"
>> if ($verbose);
>> $tmp = $sections[$idx];
>>
>> if ($tmp =~ /LICENSE/) {
>>
>> &checkorder('LICENSE', $tmp, $file, qw(
>> LICENSE LICENSE_COMB LICENSE_GROUPS LICENSE_NAME
>>
>> LICENSE_TEXT LICENSE_FILE LICENSE_PERMS
>> ));
>> $tmp may not contain license example:
>> 13 MAINTAINER= ports at FreeBSD.org
>> 14 COMMENT= Versatile softsynth implemented as a DSSI plugin
>> 15
>> 16 BUILD_DEPENDS= ${LOCALBASE}/include/dssi.h:${PORTSDIR}/audio/dssi \
>> 17 ${LOCALBASE}/include/ladspa.h:${PORTSDIR}/audio/ladspa
>> 18 LIB_DEPENDS= dssialsacompat.0:${PORTSDIR}/audio/libdssialsacompat
\
>> 19 lo.7:${PORTSDIR}/audio/liblo \
>> 20 jack.0:${PORTSDIR}/audio/jack \
>> 21 fftw3f.5:${PORTSDIR}/math/fftw3-float
>> 22
>> 23 LICENSE= GPLv2 LGPL21
>>
>> Any ideas..
>>
>>
>> --
>> Best regards.
>> Ilya A. Arkhipov
>>
>
> Hi All,
>
> Please test this patch
http://micro.heavennet.ru/ports/portlint/portlint.patch
>
>
Did you send a PR? It'd be much easier for us to track.
Chris
More information about the freebsd-ports
mailing list