Wacom driver

[bomberboy]

On Wed, Nov 5, 2008 at 11:22 AM, Dominic Fandrey <kamikaze at bsdforen.de> wrote:

Hello,

> I have created a port of Bartosz Fabianowski's Wacom driver.
> Since nobody has stepped forward to commit it, I thought I'd
> inform this list, so that people can test it.
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=128547

I tried compiling it my system but building the port fails for me.
Two diffs are attached, one for the Makefile of the port itself and
one for uwacom.c in the code of Bartosz Fabianowski.

My system is running a recent current btw:
# uname -a
FreeBSD Tablet.lan 8.0-CURRENT FreeBSD 8.0-CURRENT #2: Tue Nov  4
15:27:47 CET 2008     root at Tablet.lan:/usr/obj/usr/src/sys/TABLET
amd64

makefile.diff :
The Makefile of the port tries to create a link to the linuxwacom
archive in the work-dir of the port.
However, this archive is located in /usr/ports/distfiles/xorg/driver/
in stead of just /usr/ports/distfiles/ (or is this something specific
to current?)

uwacom.diff:
uwacom.c is missing the include <sys/clist.h>
Maybe this was indirectly included in a different header file in 6.x or 7.0?

After these changes the compile of uwacom.c still fails with:
=========
cc -O2 -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE
-std=c99 -nostdinc   -I. -I@ -I@/contrib/altq -finline-limit=8000
--param inline-unit-growth=100 --param large-function-growth=1000
-fno-common  -fno-omit-frame-pointer -mcmodel=kernel -mno-red-zone
-mfpmath=387 -mno-sse -mno-sse2 -mno-sse3 -mno-mmx -mno-3dnow
-msoft-float -fno-asynchronous-unwind-tables -ffreestanding
-fstack-protector -fstack-protector -Wall -Wredundant-decls
-Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes
-Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign
-fformat-extensions -c uwacom.c
cc1: warnings being treated as errors
uwacom.c: In function 'uwacom_init':
uwacom.c:1072: warning: left shift count >= width of type
*** Error code 1

Stop in /usr/ports/x11-drivers/xf86-input-wacom/work/uwacom.
*** Error code 1
=========

Removing -Werror from the compile step silently ignores this warning,
but I guess that's not the right way to deal with this :)
I'm not familiar with the code at all and don't really know how to
solve this, but maybe you do.

Can't verify if it works though, I'm using it on a Tablet PC (Fujitsu
T4220) for which the wacom device should show up as a serial device.
(However, I'm still having some problems with that though)

As a sidenote. The tablets which use a serial port (e.g. most
tabletPCs according to the linuxwacom documentation) don't need the
the usb-part if I'm correct. So maybe it would be a good idea to split
the port into two parts? One just for the linuxwacom codebase, and one
for the kernel module? (which then depends on the linuxwacom port)


Kind regards,
Bruno
-------------- next part --------------
A non-text attachment was scrubbed...
Name: makefile.diff
Type: application/octet-stream
Size: 313 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20081105/90928bfa/makefile.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: uwacom.diff
Type: application/octet-stream
Size: 269 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20081105/90928bfa/uwacom.obj