Mk/bsd.openssl.mk optimization

[Sean C. Farley]

On Tue, 29 Jul 2008, Freddie Cash wrote:

> On July 29, 2008 12:52 pm V.Chukharev wrote:
>> Another patch, just one line. It can be applied independently from the
>> patch for bsd.port.subdir.mk.
>>
>> =============
>> --- /usr/ports/Mk/bsd.openssl.mk.orig	2008-07-23 09:14:29.000000000
>> +0300 +++ /usr/ports/Mk/bsd.openssl.mk	2008-07-29 20:35:05.000000000
>> +0300 @@ -121,7 +121,7 @@
>>  	exists(${DESTDIR}/${LOCALBASE}/lib/libcrypto.so)
>>  # find installed port and use it for dependency
>>  PKG_DBDIR?=		${DESTDIR}/var/db/pkg
>> -OPENSSL_INSTALLED!=	grep -l -r "^lib/libssl.so." "${PKG_DBDIR}" | \
>> +OPENSSL_INSTALLED!=	find "${PKG_DBDIR}" -type f -name "+CONTENTS"
>> -print0 | xargs -0 grep -l "^lib/libssl.so." | \ while read contents;
>
> Is piping this into xargs faster/better than using -exec option to
> find?

I was curious about the same thing.

> find "${PKG_DBDIR}" -type f -name "+CONTENTS" -exec \
> grep -l "^lib/libssl.so." {} \;

Even better than "find ... {} \;" would be "find ... {} \+" to take
advantage of the xargs-like behavior of find.

Sean
-- 
scf at FreeBSD.org