amule 2 port - trying an upgrade

[Dmitry Marakasov]

* Torfinn Ingolfsen (tingox at gmail.com) wrote:

> >> +USE_GETTEXT= yes
> > Using gettext conditionally like before no longer work?
> I don't really know. What exactly do we gain by using gettext conditionally?

Optional NLS support. Less depends, not installing unneeded locales if
NLS is not needed.

> >> -.if !defined(WITHOUT_OPTIMIZE)
> >> +.if defined(WITH_OPTIMIZE)
> > No, checking WITHOUT_OPTIMIZE is correct. You should check
> > counter-default values for options, i.e. check WITH_FOO if FOO is
> > off by default, and WITHOUT_FOO if FOO is on by default. Same for
> > other checks.
> 
> Is this documented in the Porters Handbook anywhere?

Doesn't look like this. Maybe it should be.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3 at amdmi3.ru  ..:  jabber: amdmi3 at jabber.ru    http://www.amdmi3.ru