amule 2 port - trying an upgrade

[Torfinn Ingolfsen]

Hi,

On Sat, Aug 23, 2008 at 12:13 AM, Dmitry Marakasov <amdmi3 at amdmi3.ru> wrote:
> I think you should hack configure with REINPLACE_CMD and change
> (configure:4643):
>
> for ac_prog in flex lex
>
> to
>
> for ac_prog in ${LOCALBASE}/flex

OK, if that is the best way, I'll do that.

> Those are because FreeBSD test doesn't support ==, so
>
> if test "$AMULECMD" == "yes"; then
>
> fails and AMULECMD_MANPAGES is thus empty.

Aha. A bashism. Thanks!


> You should REINPLACE_CMD -e '/if test/ s|==|=|' ${WRKSRC}/configure

I have fixed that now (see attached diff). I also found a similar
thing in ${WRKSRC}/automake/manpages.am and tried to fix that.
Are automake files plain sh scripts? I guess they are.
Anyway, even with my new Makefile with your fixes, the install fails:
Making install in docs
gmake[1]: Entering directory `/usr/ports/net-p2p/amule2/work/aMule-2.2.2/docs'
Making install in man
gmake[2]: Entering directory
`/usr/ports/net-p2p/amule2/work/aMule-2.2.2/docs/man'
gmake[3]: Entering directory
`/usr/ports/net-p2p/amule2/work/aMule-2.2.2/docs/man'
gmake[3]: Nothing to be done for `install-exec-am'.
gmake  install-data-hook
gmake[4]: Entering directory
`/usr/ports/net-p2p/amule2/work/aMule-2.2.2/docs/man'
test: 1: unexpected operator
 /bin/sh ../../mkinstalldirs /usr/local/man/1/man1
 install  -o root -g wheel -m 444 ./amulecmd.1
/usr/local/man/1/man1/amulecmd.1.1
test: de.1: unexpected operator
 /bin/sh ../../mkinstalldirs /usr/local/man/de/man1
 install  -o root -g wheel -m 444 ./amulecmd.de.1
/usr/local/man/de/man1/amulecmd.1
test: es.1: unexpected operator
 /bin/sh ../../mkinstalldirs /usr/local/man/es/man1
 install  -o root -g wheel -m 444 ./amulecmd.es.1
/usr/local/man/es/man1/amulecmd.1
test: eu.1: unexpected operator
 /bin/sh ../../mkinstalldirs /usr/local/man/eu/man1
 install  -o root -g wheel -m 444 ./amulecmd.eu.1
/usr/local/man/eu/man1/amulecmd.1
test: fr.1: unexpected operator
 /bin/sh ../../mkinstalldirs /usr/local/man/fr/man1
 install  -o root -g wheel -m 444 ./amulecmd.fr.1
/usr/local/man/fr/man1/amulecmd.1
test: hu.1: unexpected operator
 /bin/sh ../../mkinstalldirs /usr/local/man/hu/man1
 install  -o root -g wheel -m 444 ./amulecmd.hu.1
/usr/local/man/hu/man1/amulecmd.1
test: 1: unexpected operator
 /bin/sh ../../mkinstalldirs /usr/local/man/1/man1

I'll look harder at it tomorrow.

> (and it's good to submit that fix upstream; bashisms should be eliminated).

I have started a thread in the amule forum, and asked about this
change. We'll see what the developers say.
-- 
Regards,
Torfinn Ingolfsen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: amule2.diff
Type: text/x-diff
Size: 8208 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20080823/6e04bb31/amule2.bin