multimedia/mplayer/Makefile information request

[Scot Hetzel]

On 10/12/06, Jeremie Le Hen <jeremie at le-hen.org> wrote:
> Hi list,
>
> please Cc: me in your reply.
>
> This is not that important, but I wonder what's the point of this
> in multimedia/mplayer/Makefile:
>
> % .if !defined(WITHOUT_X11)
> % USE_XLIB=       yes
> % CFLAGS+=        -I${X11BASE}/include
> % CONFIGURE_ARGS+=--with-x11libdir=${X11BASE}/lib \
> %                 --with-x11incdir=${X11BASE}/include
> % .else
>
> If "--with-x11incdir=${X11BASE}/include" is here, what's the point
> of using "CFLAGS+= -I${X11BASE}/include" ?  It appears to be
> superfluous.
>
It looks like it might be, try commenting that line out in the
Makefile and then build, install, and test the port.  If it works,
then submit a PR to have that line removed.

Scot
-- 
DISCLAIMER:
No electrons were mamed while sending this message. Only slightly bruised.