graphics/png - CC

[[LoN]Kamikaze]

Gábor Kövesdán wrote:
> [LoN]Kamikaze wrote:
>> Gábor Kövesdán wrote:
>>  
>>> [LoN]Kamikaze wrote:
>>>    
>>>> Andrey Chernov wrote:
>>>>  
>>>>      
>>>>> On Sat, Jul 29, 2006 at 02:59:19PM -0500, Jeremy Messenger wrote:
>>>>>           
>>>>>> On Sat, 29 Jul 2006 13:27:08 -0500, [LoN]Kamikaze
>>>>>> <LoN_Kamikaze at gmx.de>  wrote:
>>>>>>
>>>>>>               
>>>>>>> Andrey Chernov wrote:
>>>>>>>                   
>>>>>>>> On Sat, Jul 29, 2006 at 01:16:47PM -0500, Jeremy Messenger wrote:
>>>>>>>>                       
>>>>>>>>> On Fri, 28 Jul 2006 18:35:14 -0500, Andrey Chernov
>>>>>>>>> <ache at FreeBSD.ORG>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>                           
>>>>>>>>>> On Fri, Jul 28, 2006 at 11:40:10AM +0200, [LoN]Kamikaze wrote:
>>>>>>>>>>                               
>>>>>>>>>>> The port graphics/png does not honour the CC Variable.
>>>>>>>>>>>                                     
>>>>>>>>>> I can't reproduce that, it honors CC for me.
>>>>>>>>>>                                 
>>>>>>>>> I can, CC=gcc will not change the CC when it compiles.
>>>>>>>>>                             
>>>>>>>> It is hard to imagine how it is ever possible. There is standard
>>>>>>>> BSD
>>>>>>>> makefile.freebsd which not owervrites CC as you can see in the
>>>>>>>> file.
>>>>>>>>                         
>>>>>> No idea, I don't know png's build system so that cc must be come
>>>>>> from  somewhere.
>>>>>>
>>>>>>               
>>>>>>> Is it possible that make.conf is read again?
>>>>>>>                     
>>>>>> I think, add "CC=${CC}" in graphics/png/Makefile's MAKE_ENV at 31
>>>>>> line  should do.
>>>>>>                 
>>>>> It will be hack for reason unknown, I prefer to avoid that.
>>>>> I normally set CC to anything and it honors.
>>>>> I never heard from somebody other than you about that problem.
>>>>> You should inspect your build path step by step to find real reason
>>>>> of that bag, only after that we can find the real fix.
>>>>>
>>>>>             
>>>> The problem is there, without doubt. Normally bsd.port.mk only
>>>> forwards CC to the configure script (look for the do-configure
>>>> target). Since the configure target is omitted the port will not
>>>> receive CC. This is why it has to be included into the make
>>>> environment. I.e. with
>>>>
>>>> MAKE_ENV+= CC="${CC}"
>>>>
>>>> This is not a hack, but a necessity, due to the lack of a configure
>>>> step.
>>>>
>>>>         
>>> Then tell me why it works for me and for Andrey.
>>>
>>>     
>>
>> Because your make.conf settings are not location sensitive. Remove the
>> setting from your make.conf and or environment. Then try:
>>
>> # make CC=/usr/local/bin/gcc42
>>
>> You will see, it will not have an effect.
>>   
> It does have.
> 
> [root at server /home/tux/wrk/ports/graphics/png]# make
> CC=/usr/local/bin/gcc42
> ===>  Extracting for png-1.2.8_3
> => MD5 Checksum OK for libpng-1.2.8.tar.bz2.
> => SHA256 Checksum OK for libpng-1.2.8.tar.bz2.
> ===>  Patching for png-1.2.8_3
> ===>  Applying FreeBSD patches for png-1.2.8_3
> ===>  Configuring for png-1.2.8_3
> ===>  Building for png-1.2.8_3
> /usr/local/bin/gcc42 -O -pipe   -I. -DPNG_USE_PNGGCCRD
> -DPNG_NO_ASSEMBLER_CODE  -c png.c
> /usr/local/bin/gcc42 -O -pipe   -I. -DPNG_USE_PNGGCCRD
> -DPNG_NO_ASSEMBLER_CODE  -c pngset.c
> /usr/local/bin/gcc42 -O -pipe   -I. -DPNG_USE_PNGGCCRD
> -DPNG_NO_ASSEMBLER_CODE  -c pngget.c
> 
> 
> The CC line in make.conf is commented out this time.
> 

Now I am confused, it works for me as well. Only my settings in make.conf are ignored.