Correctly implementing ${PREFIX}

[Jon Drews]

Port: editors/ted

Hi:

 Kris wrote me about a defect in my port:
> Dear port maintainer,
>
> This port does not respect non-standard LOCALBASE/X11BASE settings,
> which is a requirement that all FreeBSD ports should satisfy.  In this build,
> your port and all its dependencies were built with LOCALBASE=/usr/opt and
> X11BASE=/usr/X, and the build failed because of hard-coded values in your
> port

  This port does not use configure in the traditional way. Instead, in
the WRKSRC Makefile I find:

####    Actively supported 'configure' options are:
####    -------------------------------------------
####
####            --prefix                Use another place than /usr/local
####                                    for installation. E.G.
####                                    --prefix=/opt/Ted
####            --with-MOTIF            Use the Motif gui toolkit. (The
####                                    default)
####            --with-GTK              Use the Gtk+ gui toolkit. (Still
####                                    experimental)

       <Snip>

CONFIGURE_OPTIONS=--with-MOTIF

 I made a patch so that the configure options are now:

CONFIGURE_OPTIONS=--with-MOTIF --prefix=${PREFIX}

My questions now are:

1) Using this --prefix=${PREFIX} will satisfy the requirements Kris
has asked for?

2) My Makefile (for the port) has:
GNU_CONFIGURE=  yes
CONFIGURE_ARGS= --prefix=${PREFIX}
CONFIGURE_TARGET=       --build=${MACHINE_ARCH}-portbld-freebsd${OSREL}
CONFIGURE_ENV=  CC="${CC}" CFLAGS="${CFLAGS}"

it does not look like GNU_CONFIGURE=    yes  and CONFIGURE_ARGS=
--prefix=${PREFIX}, CONFIGURE_TARGET=  are being used.
  Is it OK to delete them from the port Makefile?


3) Do I need to have CONFIGURE_ENV=  CC="${CC}" CFLAGS="${CFLAGS}" ?

Thanks for any guidance on this; I am new to porting.
--
Kind regards,
Jonathan