FYI Re: astro/celestia is using an incomplete src tarball

[Paul Seniura]

Roman Neuhauser wrote:
> # pdseniura at techie.com / 2004-06-23 10:54:59 -0500:
> > if c++ -DHAVE_CONFIG_H -I. -I. -I../../.. -I../.. -I..  -I/usr/local/include  -DQT_THREAD_SUPPORT -march=pentium2 -pipe  -I/usr/local/include -I/usr/local/include  -I/usr/X11R6/include -D_GETOPT_H -D_THREAD_SAFE  -Wnon-virtual-dtor -Wno-long-long -Wundef -W -Wpointer-arith -Wmissing-prototypes -Wwrite-strings -DNDEBUG -DNO_DEBUG  -fno-exceptions -fno-check-new      -fomit-frame-pointer -DCELX  -MT kdeapp.o -MD -MP -MF ".deps/kdeapp.Tpo" \
> >   -c -o kdeapp.o `test -f 'kdeapp.cpp' || echo './'`kdeapp.cpp; \
> > then mv -f ".deps/kdeapp.Tpo" ".deps/kdeapp.Po"; \
> > else rm -f ".deps/kdeapp.Tpo"; exit 1; \
> > fi
> > In file included from ../../celengine/vertexprog.h:15,
> >                  from ../../celengine/glcontext.h:15,
> >                  from ../../celengine/render.h:18,
> >                  from ../../celengine/execenv.h:14,
> >                  from ../../celengine/command.h:15,
> >                  from ../celestiacore.h:19,
> >                  from kdeglwidget.h:25,
> >                  from kdeapp.cpp:67:
> > ../../celengine/gl.h:33:1: warning: "GL_ARB_multitexture" redefined
> > In file included from /usr/X11R6/include/GL/gl.h:2472,
> >                  from /usr/X11R6/include/qgl.h:79,
> >                  from kdeglwidget.h:21,
> >                  from kdeapp.cpp:67:
> > /usr/X11R6/include/GL/glext.h:2706:1: warning: this is the location of the previous definition
> > kdeapp.cpp: In member function `void KdeApp::initActions()':
> > kdeapp.cpp:305: warning: `key' is deprecated (declared at
> >    /usr/local/include/kstdaccel.h:420)
> > kdeapp.cpp:308: warning: `key' is deprecated (declared at
> >    /usr/local/include/kstdaccel.h:420)
> > kdeapp.cpp: In member function `void KdeApp::slotDisplayLocalTime()':
> > kdeapp.cpp:1024: error: wrong type argument to unary minus
> > kdeapp.cpp:1024: error: `daylight' undeclared (first use this function)
> > kdeapp.cpp:1024: error: (Each undeclared identifier is reported only once for
> >    each function it appears in.)
> 
>     My guess is kdeapp.cpp containes a misplaced definition of daylight
>     variable, either #ifdefed so it's not there when you compile it on
>     OSX, or the other compiler is more fogiving.

Oh yes that rang a bell - I do believe there were others in the
Celestia Forum that mentioned the same problem on Linux. 
IIRC (and I'll go look it up again) the #includes had to be
moved, and it is fixed in their CVS but no release has been
made yet.  I can't do CVS/CVSup here at work, tho; maybe they
have a nightly tarball or something.

I need WITH_KDE=yes in my /etc/make.conf for many other apps when
portupgrade is running at night in batch mode.  To get around this
dilemma, I inserted a 'forced' undef into celestia's port Makefile,
e.g.:

===cut-here===
--- Makefile_without	Thu Jun 24 13:15:46 2004
+++ Makefile	Wed Jun 23 15:01:45 2004
@@ -35,6 +35,9 @@
 	LDFLAGS="-L${X11BASE}/lib -L${LOCALBASE}/lib -lm ${PTHREAD_LIBS}" \
 	CPPFLAGS="-I${X11BASE}/include -I${LOCALBASE}/include ${PTHREAD_CFLAGS}"
 
+# pds - test compile bug
+.undef WITH_KDE
+
 .if defined(WITH_KDE)
 USE_KDELIBS_VER=	3
 CONFIGURE_ARGS+=	--with-kde
===cut-here===

so we can get the '.else' clause activated every time, for now.

It'll build clean with that undef'd while WITH_LUA=yes is still
in effect.

Haven't tested it yet, tho, still catching up...


> > But could we get the proper full tarball specs
> > put into the FreeBSD skeleton, please?  I'll
> > whip up a PR+patch asap if needed.
> 
>     Go ahead.

PR/68252: <http://www.freebsd.org/cgi/query-pr.cgi?pr=68252>


> -- 
> If you cc me or remove the list(s) completely I'll most likely ignore
> your message.    see http://www.eyrie.org./~eagle/faqs/questions.html

<sigh>  Our firewall/proxy won't let us:

"Forbidden, this page
 (http://www.eyrie.org/~eagle/faqs/questions.html)
 is categorized as: Entertainment."


  --  thx, Paul Seniura.