[Bug 255725] [Bug] pkg-config of librtlsdr (comms/rtl-sdr) unnecessarily forces -std=gnu89

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255725

            Bug ID: 255725
           Summary: [Bug] pkg-config of librtlsdr (comms/rtl-sdr)
                    unnecessarily forces -std=gnu89
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: martymac at FreeBSD.org
          Reporter: nsonack at outlook.com
          Assignee: martymac at FreeBSD.org
             Flags: maintainer-feedback?(martymac at FreeBSD.org)

Created attachment 224791
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=224791&action=edit
Proposed Patch

When I tried to build a C99 compliant piece of C code that 
depended on librtlsdr, I ran into the problem that the pkg-config
of comms/rtl-sdr in /usr/local/libdata/pkgconfig/librtlsdr.pc 
caused all builds to fail, because of C standards violation, 
which is very annoying, as the original library doesn't seem
require GNU89 C.

Building rtl-sdr by hand from the upstream source and comparing
the two .pc files, I see:

[nico at hades ~/build/rtl-sdr]$ cat librtlsdr.pc
prefix=/usr/local
exec_prefix=${prefix}
libdir=${exec_prefix}/lib
includedir=${prefix}/include

Name: RTL-SDR Library
Description: C Utility Library
Version: 0.5.4.38-0847
Cflags: -I${includedir}/
Libs: -L${libdir} -lrtlsdr
Libs.private:  -lusb-1.0  -lusb 
[nico at hades ~/build/rtl-sdr]$ cat /usr/local/libdata/pkgconfig/librtlsdr.pc 
prefix=/usr/local
exec_prefix=${prefix}
libdir=${exec_prefix}/lib
includedir=${prefix}/include

Name: RTL-SDR Library
Description: C Utility Library
Version: UNKNOWN
Cflags: -I${includedir}/ -O2 -pipe  -fstack-protector-strong
-fno-strict-aliasing -std=gnu89  
Libs: -L${libdir} -lrtlsdr
Libs.private:  -lusb 
[nico at hades ~/build/rtl-sdr]$ 

Having that in mind, I removed the line in the Makefile of the
port that forced the gnu89 "standard" and everything seems to be
working just fine.
Also, I noticed that in order to build the port, GNU make is not
required.

Attached I have a proposal for a patch to remove those strange
requirements. I have tested it on: 

[nico at hades /usr/ports/comms/rtl-sdr]$ uname -apKU
FreeBSD hades.herrhotzenplotz.geek 13.0-RELEASE FreeBSD 13.0-RELEASE #0
releng/13.0-n244733-ea31abc261f: Fri Apr  9 04:24:09 UTC 2021    
root at releng1.nyi.freebsd.org:/usr/obj/usr/src/amd64.amd64/sys/GENERIC  amd64
amd64 1300139 1300139
[nico at hades /usr/ports/comms/rtl-sdr]$ 

If the dependency on GNU Make or GNU89 C is because of a different 
CPU architecture, I would suggest to make those requirements 
specific to the platform.

Please correct me if I am wrong with any of my previous statements.

-- 
You are receiving this mail because:
You are the assignee for the bug.