[Bug 253782] New port: www/py-adblock Brave's adblock library in Python

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253782

--- Comment #3 from Adam Jimerson <vendion at gmail.com> ---
Thanks for the feedback!

> Why not using dns/public_suffix_list instead of maintaining a public suffix list in this port?
Using dns/public_suffix_list would also mean this port agrees with other ports
about public suffixes

I was not aware that dns/public_suffix_list existed, that is certainly better
than having to patch in my own list.

> Maybe use ${WITH_DEBUG:D:U--strip} instead of --strip there (as suggested by make(1) for values that are only needed when a variable is undefined)

Good point, I'll add that to my do-build target, so those wont get stripped if
WITH_DEBUG is set for the port.

-- 
You are receiving this mail because:
You are the assignee for the bug.