[Bug 252085] new port: editors/codelite-devel: powerful open-source, cross platform code editor for the C/C++ programming languages (development version)

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252085

--- Comment #4 from daniel.engberg.lists at pyret.net ---
Hi Ivan,

Can we transfer this to the main port instead? It's soon going to be broken due
to bumping pango.

A few things that can be improved by looking at your Makefile

L4 and L26: Please follow Porter's Handbook 
https://docs.freebsd.org/en_US.ISO8859-1/books/porters-handbook/book.html#makefile-master_sites-github-ex5

L12 Seems to be GPLv2 ?
Define LICENSE_FILE
https://docs.freebsd.org/en_US.ISO8859-1/books/porters-handbook/book.html#licenses-license_file-ex1

L17 Remove?

L27 is already defined by the framework
https://svnweb.freebsd.org/ports/head/Mk/Uses/cmake.mk?revision=488341&view=markup#l68

L34 is this really needed and if it is, please use a proper DEBUG menu option
https://github.com/eranif/codelite/blob/master/CMakeLists.txt#L429

L105, are you really sure about that?

There is quite a bit of REINPLACE_CMD going on, this is in general discouraged
perhaps usage can be reduced and replaced with patches?

Some things are out of order, have a look at portlint and/or portclippy

Does it pass poudriere?

Great work!
Daniel

-- 
You are receiving this mail because:
You are the assignee for the bug.