[Bug 253278] x11-servers/xorg-server: Lock file: Various fixes

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253278

            Bug ID: 253278
           Summary: x11-servers/xorg-server: Lock file: Various fixes
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: x11 at FreeBSD.org
          Reporter: olivier.freebsd at free.fr
          Assignee: x11 at FreeBSD.org
             Flags: maintainer-feedback?(x11 at FreeBSD.org)

Created attachment 222190
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=222190&action=edit
Patch against the ports tree

Several fixes:

1. Create a lock file in the case of an explicitly requested display even if
"-displayfd" was specified. This is because, in this case, the server creation
process is essentially the same as when "-displayfd" is not specified. The only
difference with the latter case should be that Xorg outputs the passed display
to the display FD (only the display selection logic is bypassed).

2. Properly indicate an unexpected problem with link(2), instead of assuming
that a failure always means that the file indeed exists.

3. Workaround for what appears to be a FreeBSD bug (link returns EPERM when
hard linking a file whose permissions are the result of creating a file in a
directory with sticky bit, although creating a separate copy is perfectly
possible). Additional benefit: Simplifies the cumbersome logic, which on POSIX
systems is unnecessary IMHO (initial lock file creation with O_EXCL is enough
to ensure mutual exclusion).

Again I'm submitting this here, since upstream seems inactive.

-- 
You are receiving this mail because:
You are the assignee for the bug.