[Bug 250800] mail/postfixadmin: requires XMLRPC and thus fails to build with PHP 8.0

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250800

--- Comment #7 from Rin Morningstar <ports.maintainer at evilphi.com> ---
ExecSum: no change needed, port works correctly by sheer luck, dead code will
be trimmed later.  Close PR as FIXED.

When fluffy touched mail/postfixadmin back in December, they ignored this PR. 
The commit message included a note about me having two months to "react and
fix" php80 support.  That was more than a month after this PR was approved for
commit.

The change fluffy made tested FLAVOR in an unflavoured port.  That would have
resulted in a no-op change, but they also made a typo and wrote "USE_PHP_="
instead of "USE_PHP+=".  This dropped xmlrpc support for all versions of PHP,
yielding a shallow positive result of letting the port build with php80.

The port then sat until 2 March, when portmgr fixed the USE_PHP_ typo but
didn't correct FLAVOR to PHP_VER, turning fluffy's change into a no-op and
adding xmlrpc to USE_PHP for all PHP versions, breaking the build for php80.

On 28 March, net/pecl-xmlrpc was added and the Uses framework was updated to
correctly choose between net/php*-xmlrpc or net/pecl-xmlrpc depending on
PHP_VER, making the port once again build for all versions of PHP.

Other than this PR, no one mentioned PostfixAdmin not building for php80.  Nor
did anyone complain about missing XML-RPC support.

In a later update, I revert the USE_PHP bits to how they were with r535201.

FWIW, XML-RPC support in PostfixAdmin is moribund.  See issue #395 on the
Github: https://github.com/postfixadmin/postfixadmin/issues/395

If you do need XML-RPC support, please mention it on Github and say what you're
using it for. The only thing I know of that used it was a password-change
plugin for the long-defunct Squirrelmail webmail app.

At this point, this PR can be closed FIXED due to externalities.

-- 
You are receiving this mail because:
You are the assignee for the bug.