[Bug 250952] converters/wkhtmltopdf: fix build on arm64/aarch64

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250952

            Bug ID: 250952
           Summary: converters/wkhtmltopdf: fix build on arm64/aarch64
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: pi at FreeBSD.org
          Reporter: rasmus at gal.dk
          Assignee: pi at FreeBSD.org
             Flags: maintainer-feedback?(pi at FreeBSD.org)

CPU isn't correctly tested on arm64 platform for qt. 

If two lines are changed in
src/3rdparty/webkit/Source/JavaScriptCore/wtf/Platform.h, it fixes all build
errors on the arch. 

Line 1000 and onward can be changed from:

#if (CPU(X86_64) && (OS(UNIX) || OS(WINDOWS))) 
|| (CPU(IA64) && !CPU(IA64_32)) 
|| CPU(ALPHA) 
|| CPU(SPARC64) 
|| CPU(S390X) 
|| CPU(PPC64) 
|| CPU(MIPS64)
#define WTF_USE_JSVALUE64 1

to:

#if (CPU(X86_64) && (OS(UNIX) || OS(WINDOWS))) 
|| (CPU(IA64) && !CPU(IA64_32)) 
|| CPU(ALPHA) 
|| CPU(SPARC64) 
|| CPU(S390X) 
|| CPU(PPC64) 
|| CPU(MIPS64) 
|| defined(aarch64)
#define WTF_USE_JSVALUE64 1

Of course I sent the above fix to the authors of the software as well:

https://github.com/wkhtmltopdf/wkhtmltopdf/issues/4871

But the port is currently disabled in the ports tree on arm64 because of this
defect.

There may be a better way to detect arm64, but the above fix works fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.