[Bug 250876] devel/gindent: update port
bugzilla-noreply at freebsd.org
bugzilla-noreply at freebsd.org
Thu Nov 5 10:59:30 UTC 2020
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250876
Bug ID: 250876
Summary: devel/gindent: update port
Product: Ports & Packages
Version: Latest
Hardware: Any
OS: Any
Status: New
Severity: Affects Some People
Priority: ---
Component: Individual Port(s)
Assignee: ports-bugs at FreeBSD.org
Reporter: moritz at schmi.tt
Created attachment 219367
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=219367&action=edit
Update of devel/gindent
o Patch buggy patch-src_args.c. It segfaults when used with -orig, -knf, -kr,
or -gnu.
The extension of the options struct in args.c by *_PRO_SETTINGS is broken.
For p_obj a string of a group of options is given. However, in the
PRO_SETTINGS case, set_option() expects an index for the settings_string
array instead.
Details:
- Remove BSD_PRO_SETTINGS as its string matches exactly
ORIG_SETTINGS_STRING. So the intended behavior of -orig is already
available.
- Remove KR_PRO_SETTINGS as it does not correspond to Kernighan-Ritchie
style. The flags -sar and -par seem to be missing. Since they are
included in KR_SETTINGS_STRING, use that string instead.
- Remove GNU_PRO_SETTINGS as its string matches exactly
GNU_SETTINGS_STRING; use it instead.
- Remove KNF_PRO_SETTINGS and introduce KNF_SETTINGS_STRING and use it
like the other settings strings.
This makes a version bump necessary, we therefore set PORTREVISION=1.
o Patch Makefile.in to make --htmldir work. Remove post-install target as it's
not necessary anymore.
o Change PORTVERSION to DISTVERSION (PHB Sect. 5.2.2). Modify DISTNAME
accordingly.
o Make COMMENT more meaningful.
o Remove MAKE_JOBS_UNSAFE as tests suggest that it's not necessary (anymore).
o Add groff:run to USES variable. This registers a dependency on
textproc/groff. It's needed to render the manpage.
o Added description for NLS option, which is slightly more verbose then the
default description.
This update is related to bug #250811, which may be closed.
--
You are receiving this mail because:
You are the assignee for the bug.
More information about the freebsd-ports-bugs
mailing list