[Bug 247583] databases/grass7: Minor problems with Makefile (and pkg-plist)

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=247583

            Bug ID: 247583
           Summary: databases/grass7: Minor problems with Makefile (and
                    pkg-plist)
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: lbartoletti at FreeBSD.org
          Reporter: rhurlin at gwdg.de
             Flags: maintainer-feedback?(lbartoletti at FreeBSD.org)
          Assignee: lbartoletti at FreeBSD.org

Created attachment 215978
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=215978&action=edit
Makefile changes to make portlint happy

Thanks for the recent update of GRASS7, much appreciated!

On my box running 13.0-CURRENT I normally build ports with having
'DEVELOPER=yes' enabled in head /etc/make.conf. For your newest port update it
gives me:


!\ grass7-7.8.3: Makefile errors /!\

you cannot include bsd.port[.pre].mk twice

Defining both PORTVERSION and DISTVERSION is wrong, only set one, if necessary,
set DISTNAME

*** Error code 1

Stop.
make[1]: stopped in /usr/ports/databases/grass7


This happens because you changed bsd.port.options.mk into bsd.port.pre.mk, but
not also changed bsd.port.mk into bsd.port.post.mk at the end of the file.



Some other problems are shown by 'portlint -AC':

WARN: /usr/ports/databases/grass7/pkg-plist: [15]: enumerating info files in
the plist is deprecated in favor of adding info files into the Makefile using
the INFO macro.
WARN: /usr/ports/databases/grass7/pkg-plist: [155]: enumerating info files in
the plist is deprecated in favor of adding info files into the Makefile using
the INFO macro.
WARN: /usr/ports/databases/grass7/pkg-plist: [274]: enumerating info files in
the plist is deprecated in favor of adding info files into the Makefile using
the INFO macro.
WARN: /usr/ports/databases/grass7/pkg-plist: [323]: enumerating info files in
the plist is deprecated in favor of adding info files into the Makefile using
the INFO macro.
WARN: /usr/ports/databases/grass7/pkg-plist: [3837]: enumerating info files in
the plist is deprecated in favor of adding info files into the Makefile using
the INFO macro.
WARN: Makefile: [135]: use a tab (not space) after a variable name
WARN: Makefile: [137]: use a tab (not space) after a variable name
WARN: Makefile: [205]: possible direct use of command "echo" found. use
${ECHO_CMD} or ${ECHO_MSG} instead.
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to
make SVN happy.
0 fatal errors and 9 warnings found.


The Makefile warnings at lines 135 and 137 are solved by a change of some
spaces into a tab. The warning in line 205 is harmless, because echo is a
filename here, not a command.

I am not sure, if the .info files in pkg-plist should remain here or as
suggested by portlint, better should be listed in the Makefile after an INFO
macro. Probably it is much more clear for now to let them in pkg-plist.


For the Makefile changes a patch is attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.