[Bug 248323] databases/sqlite3: Line editing library options broken

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=248323

            Bug ID: 248323
           Summary: databases/sqlite3: Line editing library options broken
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs at FreeBSD.org
          Reporter: madpilot at FreeBSD.org
                CC: pavelivolkov at gmail.com, sunpoet at FreeBSD.org
            Blocks: 239228
                CC: pavelivolkov at gmail.com
             Flags: maintainer-feedback?(pavelivolkov at gmail.com)
 Attachment #216835 maintainer-approval?(pavelivolkov at gmail.com)
             Flags:
             Flags: maintainer-feedback?(pavelivolkov at gmail.com)

Created attachment 216835
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=216835&action=edit
Fix for sqlite3 readline/libedit options

Hi,

I just noticed that after r542047 has been committed the options to have a line
editing library linked with sqlite3 are all broken.

At present the port defines option names READLINES, READLINEP and EDITLINE, but
then uses option helpers for option name READLINE and LIBEDIT. This makes it
impossible to have the port link with any of these libraries.

This has also been noticed by sunpoet in a message to svn-ports-all.

r542047 also removed all these options descriptions, which I'm putting back
with slightly changed text.

While here I also made the other descriptions all start with upper case
letters, as is usually done.

I'm attaching a patch partly reverting r542047, putting back READLINES and
READLINEP option helpers, and also fixing the EDITLINE/LIBEDIT incongruity. I'm
leaving the change of default to libedit and moving from OPTIONS_GROUP to
OPTIONS_RADIO.

BTW the change to OPTIONS_RADIO also fixes bug 239228, which I'm referencing
from this bug.

I'd like to commit this soon to fix the immediate issue and add back the option
to have a line editing library linked in sqlite3.

If further changes are planned to the port those can be discussed later.


Referenced Bugs:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239228
[Bug 239228] databases/sqlite3: sqlite3-3.28.0 config interface should restrict
READLINES vs READLINEP options
-- 
You are receiving this mail because:
You are the assignee for the bug.